Felix watches bgpPeer and process localWorkloadSelector. - #8
Open
song-jiang wants to merge 1 commit into
Open
Conversation
song-jiang
pushed a commit
that referenced
this pull request
Mar 30, 2026
song-jiang
added a commit
that referenced
this pull request
Jun 3, 2026
- Replace Feature:KubeVirt-KIND with RequiresRealKubeVirt requirement label so KIND lane includes Feature:KubeVirt and excludes RequiresRealKubeVirt instead of double-tagging tests with two features (Casey #1). - Add back isKINDCluster guards with explicit failure messages explaining why the test cannot run on KIND (Casey #2). - Split live_migration_kind.go: move helpers (kindBIRDPeer, setupKindEBGPPeering, expectMigrationFailed) into utils.go, keep only test suite in the file (Casey #3). - Use existing WithExternalNode() label instead of RequiresExternalNode() to avoid duplicate labels with same semantics (skoryk #7). - Move WithSerial() from describe block to eBGP It only — other tests are namespace-scoped and parallel-safe (skoryk #8). - Add nil guard for net.ParseIP().To4() in querySnapshot and queryTORSnapshot to prevent panic on malformed/IPv6 input (skoryk #9). - Remove duplicate NetworkPolicy test from live_migration.go — the KIND ICMP version provides equivalent coverage without requiring a real guest OS (skoryk projectcalico#10). - Randomize BIRD container name with GenerateRandomName to prevent collisions on parallel runs (skoryk projectcalico#11). - Change queryWorkerMetric to return (int, error) so failures surface the real cause instead of hiding it behind a -1 sentinel (skoryk projectcalico#13). - Add non-go:/e2e/pkg/ to CHANGE_IN macro so test file changes trigger the KubeVirt KIND CI lane (skoryk projectcalico#14). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
song-jiang
added a commit
that referenced
this pull request
Jun 3, 2026
- Replace Feature:KubeVirt-KIND with RequiresRealKubeVirt requirement label so KIND lane includes Feature:KubeVirt and excludes RequiresRealKubeVirt instead of double-tagging tests with two features (Casey #1). - Add back isKINDCluster guards with explicit failure messages explaining why the test cannot run on KIND (Casey #2). - Split live_migration_kind.go: move helpers (kindBIRDPeer, setupKindEBGPPeering, expectMigrationFailed) into utils.go, keep only test suite in the file (Casey #3). - Use existing WithExternalNode() label instead of RequiresExternalNode() to avoid duplicate labels with same semantics (skoryk #7). - Move WithSerial() from describe block to eBGP It only — other tests are namespace-scoped and parallel-safe (skoryk #8). - Add nil guard for net.ParseIP().To4() in querySnapshot and queryTORSnapshot to prevent panic on malformed/IPv6 input (skoryk #9). - Remove duplicate NetworkPolicy test from live_migration.go — the KIND ICMP version provides equivalent coverage without requiring a real guest OS (skoryk projectcalico#10). - Randomize BIRD container name with GenerateRandomName to prevent collisions on parallel runs (skoryk projectcalico#11). - Change queryWorkerMetric to return (int, error) so failures surface the real cause instead of hiding it behind a -1 sentinel (skoryk projectcalico#13). - Add non-go:/e2e/pkg/ to CHANGE_IN macro so test file changes trigger the KubeVirt KIND CI lane (skoryk projectcalico#14). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
song-jiang
added a commit
that referenced
this pull request
Jun 3, 2026
- Replace Feature:KubeVirt-KIND with RequiresRealKubeVirt requirement label so KIND lane includes Feature:KubeVirt and excludes RequiresRealKubeVirt instead of double-tagging tests with two features (Casey #1). - Add back isKINDCluster guards with explicit failure messages explaining why the test cannot run on KIND (Casey #2). - Split live_migration_kind.go: move helpers (kindBIRDPeer, setupKindEBGPPeering, expectMigrationFailed) into utils.go, keep only test suite in the file (Casey #3). - Use existing WithExternalNode() label instead of RequiresExternalNode() to avoid duplicate labels with same semantics (skoryk #7). - Move WithSerial() from describe block to eBGP It only — other tests are namespace-scoped and parallel-safe (skoryk #8). - Add nil guard for net.ParseIP().To4() in querySnapshot and queryTORSnapshot to prevent panic on malformed/IPv6 input (skoryk #9). - Remove duplicate NetworkPolicy test from live_migration.go — the KIND ICMP version provides equivalent coverage without requiring a real guest OS (skoryk projectcalico#10). - Randomize BIRD container name with GenerateRandomName to prevent collisions on parallel runs (skoryk projectcalico#11). - Change queryWorkerMetric to return (int, error) so failures surface the real cause instead of hiding it behind a -1 sentinel (skoryk projectcalico#13). - Add non-go:/e2e/pkg/ to CHANGE_IN macro so test file changes trigger the KubeVirt KIND CI lane (skoryk projectcalico#14). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
song-jiang
added a commit
that referenced
this pull request
Jun 3, 2026
- Replace Feature:KubeVirt-KIND with RequiresRealKubeVirt requirement label so KIND lane includes Feature:KubeVirt and excludes RequiresRealKubeVirt instead of double-tagging tests with two features (Casey #1). - Add back isKINDCluster guards with explicit failure messages explaining why the test cannot run on KIND (Casey #2). - Split live_migration_kind.go: move helpers (kindBIRDPeer, setupKindEBGPPeering, expectMigrationFailed) into utils.go, keep only test suite in the file (Casey #3). - Use existing WithExternalNode() label instead of RequiresExternalNode() to avoid duplicate labels with same semantics (skoryk #7). - Move WithSerial() from describe block to eBGP It only — other tests are namespace-scoped and parallel-safe (skoryk #8). - Add nil guard for net.ParseIP().To4() in querySnapshot and queryTORSnapshot to prevent panic on malformed/IPv6 input (skoryk #9). - Remove duplicate NetworkPolicy test from live_migration.go — the KIND ICMP version provides equivalent coverage without requiring a real guest OS (skoryk projectcalico#10). - Randomize BIRD container name with GenerateRandomName to prevent collisions on parallel runs (skoryk projectcalico#11). - Change queryWorkerMetric to return (int, error) so failures surface the real cause instead of hiding it behind a -1 sentinel (skoryk projectcalico#13). - Add non-go:/e2e/pkg/ to CHANGE_IN macro so test file changes trigger the KubeVirt KIND CI lane (skoryk projectcalico#14). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.