Admin payment methods crud #6302
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to clean up existing forms and write more concise forms in the future. Custom form builder encapsulates all the calls to "render", "component()" initializations, and assumes some defaults, e.g. if "checked" is not passed to "f.checkbox" we get it by calling @object.send(method)
Inherit from resources controller, define necessary overriding methods.
Render links in the table.
Removes row_url and replaces it with edit_path and usages of new routing paths.
For validation errors to be shown correctly we need a proper identifier for turbo stream to replace, default one used by resources controller is :resource_modal but this name does not fit for our page so we use a custom name.
github-actions
bot
added
changelog:solidus_core
chaimann
force-pushed
the
admin-payment-methods-crud
branch
from
9bc04e4 to
e701f96
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6302 +/- ##
==========================================
+ Coverage 86.65% 88.97% +2.31%
==========================================
Files 521 867 +346
Lines 11943 18471 +6528
==========================================
+ Hits 10349 16434 +6085
- Misses 1594 2037 +443 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
blocked by #6294
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: