[Admin] Confirmation modal #6295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaimann
force-pushed
the
admin-confirm-modal
branch
from
e8a5321 to
e0ab3ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6295 +/- ##
=======================================
Coverage 88.97% 88.98%
=======================================
Files 861 862 +1
Lines 18416 18422 +6
=======================================
+ Hits 16386 16392 +6
Misses 2030 2030 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chaimann
force-pushed
the
admin-confirm-modal
branch
from
e0ab3ca to
d2d5a3c
Compare
chaimann
force-pushed
the
admin-confirm-modal
branch
from
d2d5a3c to
d54d00a
Compare
* adds possibility to conditionally open modal on connect - use stimulus value instead of Dialog's "open" attribute (applying attribute directly on dialog element is discouraged by HTML specification https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/open#value); * adds identifier classes to title ".modal-title" and body ".modal-body" so that turbo-confirm can target them correctly; * adds "empty:hidden" so that when no content is passed the empty div does not take space in the modal;
chaimann
force-pushed
the
admin-confirm-modal
branch
2 times, most recently
from
4060de4 to
c20f8dc
Compare
Updates several components to use "data-turbo-confirm" and new confirmation dialog instead of native browser confirm. Removes redundant confirm_controller.js.
Default animation duration was 300ms. It controls how long turbo-control will wait before restoring default confirm modal content (empty template). Due to that there could be a condition if you click fast enough when requesting a different confirm dialog, e.g. in products table clicking "Delete", closing modal and then clicking "Deactivate", then modal contents would be overwritten with previous modal contents. Since we don't use any kind of animation for modals we can put 0 duration to mitigate that bug.
chaimann
force-pushed
the
admin-confirm-modal
branch
from
c20f8dc to
28d04f0
Compare
adammathys
approved these changes
Jul 24, 2025
jarednorman
approved these changes
Jul 24, 2025
|
This has a conflict that needs addressing. |
benjaminwil
approved these changes
Jul 24, 2025
tvdeyen
requested changes
Aug 5, 2025
There was a problem hiding this comment.
I would love to not use an external gem for a simple task as adding a function that opens a Dialog on data-turbo-confirm https://turbo.hotwired.dev/reference/drive#turbo.config.forms.confirm
We already have a Dialog handler that we use to open dialogs. We should use that instead of an external library that very likely will stop receiving updates in a few months.
|
For the time being we can continue to use the native confirm that Turbo is using. No user will see a difference anyway. Maybe there area some relevant changes in this 10 commits PR that we can extract.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using turbo-confirm add-on create a UI confirmation modal component to use Turbo-native "data-turbo-confirm" functionality along with custom modal dialog, rather than browser native confirm dialog.
Screenshots
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: