[Admin][Products] Product option types list #6283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_core
chaimann
force-pushed
the
admin-product-option-types-list
branch
6 times, most recently
from
786b4b2 to
fdb49ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6283 +/- ##
==========================================
+ Coverage 86.65% 88.99% +2.33%
==========================================
Files 521 863 +342
Lines 11943 18430 +6487
==========================================
+ Hits 10349 16401 +6052
- Misses 1594 2029 +435 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chaimann
force-pushed
the
admin-product-option-types-list
branch
2 times, most recently
from
aae1bad to
b9643ab
Compare
|
The commit history seems to need some fixup commits. |
chaimann
force-pushed
the
admin-product-option-types-list
branch
from
b9643ab to
1b6f163
Compare
Follow common pattern for flashes everywhere else in admin.
Responsible for sorting on backend
Delegate option type methods #name, #presentation, #option_values for easier access in the view.
Add a section in Options panel to display all saved product option types along with associated option values. Make them sortable and show "Edit" button in front of each option that would direct to the edit page of respective option type.
Adds a submit button to save selected options and a hidden field to allow removing all saved options.
This way it mimics how they are displayed in the list.
Link to option types page.
If sortable elements have a handle we need to account for it, so that drag and drop can be performed correctly.
chaimann
force-pushed
the
admin-product-option-types-list
branch
from
1b6f163 to
add36d3
Compare
benjaminwil
approved these changes
Jul 24, 2025
jarednorman
requested changes
Jul 24, 2025
| belongs_to :option_type, class_name: 'Spree::OptionType', inverse_of: :product_option_types | ||
| acts_as_list scope: :product | ||
|
|
||
| delegate :name, :presentation, :option_values, to: :option_type |
There was a problem hiding this comment.
This delegation seems somewhat arbitrary. I don't think we should add to the API of this class just to make a couple of calls in the view more convenient. I think this actually makes the view more confusing because it obfuscates where this information is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of Solidus Admin
Contains partial changes from #6282(branch in main, and already rebased)Summary
Implements a list of associated product options types.
Features
Demo
Screen.Recording.2025-06-10.at.15.54.24.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: