Skip to content

Conversation

@atilafassina
Copy link
Member

we have been consuming start and the nitro plugin from /src, this PR changes the exports in the start package so it can also be consumed from /dist.

it also adds a dedicated fixture for Nitro v3

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: 353f677

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 353f677
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6922c82fbb1dcc000899103f
😎 Deploy Preview https://deploy-preview-2008--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atilafassina atilafassina force-pushed the fixtures/consume-from-workspace branch 4 times, most recently from 67d5ca6 to 0d793ac Compare November 20, 2025 18:06
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2008

commit: 353f677

@atilafassina atilafassina force-pushed the fixtures/consume-from-workspace branch 2 times, most recently from dfa12cb to ef11bc6 Compare November 20, 2025 18:09
@atilafassina atilafassina changed the title consume packages from dist / add nitro 3 fixture add nitro 3 fixture - fix landing page build Nov 20, 2025
@Brendonovich Brendonovich force-pushed the fixtures/consume-from-workspace branch from 8f98359 to f60db4a Compare November 22, 2025 04:21
Copy link
Contributor

@brenelz brenelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here. One conflict to resolve

@atilafassina atilafassina force-pushed the fixtures/consume-from-workspace branch from f60db4a to e5be5a9 Compare November 23, 2025 08:31
@atilafassina atilafassina merged commit 7550f7c into main Nov 23, 2025
9 checks passed
@atilafassina atilafassina deleted the fixtures/consume-from-workspace branch November 23, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants