-
Notifications
You must be signed in to change notification settings - Fork 401
VItest + Playwright migration #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Some build errors that look like this: was why i created #2001 |
|
Also complaining about
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the test infrastructure from Cypress to Vitest + Playwright. The migration separates unit tests (Vitest) from end-to-end tests (Playwright), introducing a dual-project Vitest configuration to run tests in both Node and browser environments. The PR also includes code formatting changes that were likely applied by a linter.
- Migrates all E2E tests from Cypress to Playwright with equivalent assertions
- Updates Vitest configuration to support both Node-based and browser-based unit tests
- Removes Cypress dependencies and adds Playwright and Vitest browser dependencies
- Updates documentation to reflect the new testing approach
Reviewed changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/start/src/config/manifest.ts | Code formatting changes (tabs to spaces, line breaks) |
| packages/start/package.json | Bumps vitest from 3.0.5 to ^4.0.10 |
| package.json | Removes cypress dependency from root |
| apps/tests/vitest.config.ts | Adds dual-project configuration for Node and browser tests |
| apps/tests/test-results/.last-run.json | Adds Playwright test results metadata |
| apps/tests/src/routes/treeshaking/treeshake.test.ts | Deleted (migrated to treeshake.server.test.ts) |
| apps/tests/src/routes/treeshaking/treeshake.server.test.ts | New server-side unit test for treeshaking |
| apps/tests/src/routes/api/text-plain.tsx | Deleted (replaced with .ts version) |
| apps/tests/src/routes/api/text-plain.ts | Simplified API route handler |
| apps/tests/src/routes/(basic).browser.test.tsx | New browser-based unit test for component |
| apps/tests/src/e2e/*.test.ts | New Playwright E2E tests (server-function, route-groups, hydration, api-call) |
| apps/tests/playwright.config.ts | Playwright configuration for E2E tests |
| apps/tests/package.json | Updates dependencies and test scripts |
| apps/tests/cypress/* | Removes all Cypress files and configuration |
| README.md | Updates testing instructions for Playwright |
| CONTRIBUTING.md | Updates testing conventions and guidance |
| .gitignore | Replaces Cypress screenshot ignore with test-results |
| .github/workflows/tests.yml | Updates CI workflow to use Playwright instead of Cypress |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.