Skip to content

Conversation

@DBozhinovski
Copy link
Collaborator

@DBozhinovski DBozhinovski commented Nov 18, 2025

  • Migrates to Vitest + Playwright from Cypress
  • Updates tests.yml for GH actions
  • Updated README and CONTRIBUTING to reflect changes to tests

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

⚠️ No Changeset found

Latest commit: b4a7a85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit b4a7a85
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/692036764e99db00083b651a
😎 Deploy Preview https://deploy-preview-2007--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@brenelz
Copy link
Contributor

brenelz commented Nov 19, 2025

Some build errors that look like this:

import { PluginOption, ViteDevServer } from "vite";

was why i created #2001

@brenelz
Copy link
Contributor

brenelz commented Nov 19, 2025

Also complaining about

 ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with /apps/tests/package.json

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2007

commit: b4a7a85

@DBozhinovski DBozhinovski marked this pull request as ready for review November 21, 2025 09:54
@atilafassina atilafassina requested a review from Copilot November 22, 2025 18:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the test infrastructure from Cypress to Vitest + Playwright. The migration separates unit tests (Vitest) from end-to-end tests (Playwright), introducing a dual-project Vitest configuration to run tests in both Node and browser environments. The PR also includes code formatting changes that were likely applied by a linter.

  • Migrates all E2E tests from Cypress to Playwright with equivalent assertions
  • Updates Vitest configuration to support both Node-based and browser-based unit tests
  • Removes Cypress dependencies and adds Playwright and Vitest browser dependencies
  • Updates documentation to reflect the new testing approach

Reviewed changes

Copilot reviewed 25 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/start/src/config/manifest.ts Code formatting changes (tabs to spaces, line breaks)
packages/start/package.json Bumps vitest from 3.0.5 to ^4.0.10
package.json Removes cypress dependency from root
apps/tests/vitest.config.ts Adds dual-project configuration for Node and browser tests
apps/tests/test-results/.last-run.json Adds Playwright test results metadata
apps/tests/src/routes/treeshaking/treeshake.test.ts Deleted (migrated to treeshake.server.test.ts)
apps/tests/src/routes/treeshaking/treeshake.server.test.ts New server-side unit test for treeshaking
apps/tests/src/routes/api/text-plain.tsx Deleted (replaced with .ts version)
apps/tests/src/routes/api/text-plain.ts Simplified API route handler
apps/tests/src/routes/(basic).browser.test.tsx New browser-based unit test for component
apps/tests/src/e2e/*.test.ts New Playwright E2E tests (server-function, route-groups, hydration, api-call)
apps/tests/playwright.config.ts Playwright configuration for E2E tests
apps/tests/package.json Updates dependencies and test scripts
apps/tests/cypress/* Removes all Cypress files and configuration
README.md Updates testing instructions for Playwright
CONTRIBUTING.md Updates testing conventions and guidance
.gitignore Replaces Cypress screenshot ignore with test-results
.github/workflows/tests.yml Updates CI workflow to use Playwright instead of Cypress

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants