fix(rpc): Added check in get_health#562
Open
0xzrf wants to merge 1 commit intosolana-foundation:mainfrom
Open
Conversation
MicaiahReid
reviewed
Mar 9, 2026
Collaborator
MicaiahReid
left a comment
MicaiahReid
left a comment
There was a problem hiding this comment.
Hmm, I don't think this is valid indication of the health of the network. I'd expect local epoch info to differ from remote - surfpool is making blocks at an interval of whatever block time the user sets. This is likely to be pretty consistent (e.g., right at 400ms), while the remote block production my vary more, leading to drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery
Adds a check for checking current local slot against rpc slot