Draft: Update rate limit #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
There might be a point in investigating if we should abandon the RateLimiter package since it seems to have been deprecated and might have some issues. While testing I also ran in to an issue with this package as it seems to make requests a bit too quickly, resulting in a Too Many Requests error from the API if we set the requests per second to 5. This is the reason for this PR increasing the requests per second to 4.8, rather than 5 (24 per 5 seconds instead of 25 per 5 seconds) |
adamelfstrom
force-pushed
the
update-rate-limit
branch
from
05e0eab to
aae2ae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate limit of the API has been increased from 4/s to 5/s a couple of years back.
In PR #258 this limit was increased in the SDK, but was shortly reverted due to concerns of inconsistencies between legacy tokens and the new OAuth2 workflow.
After some tests with both authentication methods, it seems they are both using the same sliding window now.
Closes #322