Add isSingletonCasesEnum flag#457
Open
sake92 wants to merge 13 commits intosoftwaremill:scala3-v2from
Open
Conversation
Update sbt to 1.8.1
Update sbt to 1.8.2
…ajs-1.13.0 Update sbt-scalajs, scalajs-library_2.13, ... to 1.13.0
…n-0.4.10 Update nscplugin, sbt-scala-native, ... to 0.4.10
…ibrary-3.2.2 Update scala3-library, ... to 3.2.2
Member
|
Thanks - this isn't binary-compatible, but there's a |
Author
|
Thanks @adamw ! |
Member
|
Not yet - but we'll get there eventually :) |
Author
|
Could this be merged now? |
5 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is useful to disambiguate between "singleton cases"/simple enums and ADTs.
My concrete use case was JSON serialization:
@typefield, and other fields if they have themImplementation-wise, the official docs say that only "singleton cases" enums will have a
valuesmethod.