[LinearSolver] Add unit test for SparseLDLLinearSolver#5937
Open
bakpaul wants to merge 4 commits intosofa-framework:masterfrom
Open
[LinearSolver] Add unit test for SparseLDLLinearSolver#5937bakpaul wants to merge 4 commits intosofa-framework:masterfrom
bakpaul wants to merge 4 commits intosofa-framework:masterfrom
Conversation
bakpaul
added
pr: enhancement
alxbilger
reviewed
Feb 5, 2026
|
|
||
| for (sofa::SignedIndex i = 0; i < nbNonZero; ++i) | ||
| { | ||
| const auto value = static_cast<SReal>(fabs(sofa::helper::drand(2))); |
Contributor
There was a problem hiding this comment.
Usually in tests, I use LinearCongruentialRandomGenerator (see CompressedRowSparseMatrix_test.cpp) to enforce a portable and determinist random number generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that a core part of SOFA which is its linear solver didn't have any unit test on the actual system solving. I've added here a test on the main one.
In your opinion, is it worth it adding for the other ones that are not Eigen-based ? (or even for the eigen based ?)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if