[Framework] remove virtual keyword for final classes#5932
Open
fredroy wants to merge 1 commit intosofa-framework:masterfrom
Open
[Framework] remove virtual keyword for final classes#5932fredroy wants to merge 1 commit intosofa-framework:masterfrom
fredroy wants to merge 1 commit intosofa-framework:masterfrom
Conversation
fredroy
added
pr: fast merge
Contributor
Author
|
[ci-build][with-all-tests] |
alxbilger
approved these changes
Feb 4, 2026
bakpaul
approved these changes
Feb 4, 2026
epernod
approved these changes
Feb 5, 2026
epernod
added
pr: status ready
alxbilger
force-pushed
the
fix_warning_final_virtual
branch
from
48d2309 to
ad5014a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with clang21, ~4-5k warnings were spammed
warning: virtual method 'blockGet' is inside a 'final' class and can never be overridden [-Wunnecessary-virtual-specifier][with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if