Skip to content

[Framework] BaseMatrix:: Remove warnings about overloaded-virtual about add()#5931

Open
fredroy wants to merge 1 commit intosofa-framework:masterfrom
fredroy:fix_warning_basematrix_add
Open

[Framework] BaseMatrix:: Remove warnings about overloaded-virtual about add()#5931
fredroy wants to merge 1 commit intosofa-framework:masterfrom
fredroy:fix_warning_basematrix_add

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Feb 4, 2026

with (since?) gcc15, It is spamming ~7k warnings like:

Sofa/framework/LinearAlgebra/src/sofa/linearalgebra/BaseMatrix.h:79:18: warning: ‘virtual void sofa::linearalgebra::BaseMatrix::add(Index, Index, const sofa::type::Mat2x2f&)’ was hidden [-Woverloaded-virtual=]

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 4, 2026
@fredroy
Copy link
Contributor Author

fredroy commented Feb 4, 2026

[ci-build][with-all-tests]

@alxbilger
Copy link
Contributor

I don't know why but the scene tests did not trigger...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants