[CMake] Clean CMake lists to be able to enforce global configuration of output folders#5558
Draft
bakpaul wants to merge 4 commits intosofa-framework:masterfrom
Draft
Conversation
This was referenced Jun 24, 2025
Contributor
Author
|
[ci-build][with-all-tests][force-full-build] |
Collaborator
|
[ci-depends-on] detected during build #2. To unlock the merge button, you must
|
Collaborator
|
[ci-depends-on] detected during build #3. To unlock the merge button, you must
|
Contributor
Author
|
[ci-build][with-all-tests][force-full-build] |
Collaborator
|
[ci-depends-on] detected during build #4. To unlock the merge button, you must
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allow to have a global mechanism to enforce custom output directories for build and install tree.
This helps the process of integration SOFA in other projects that are not putting stuffs in the same place as us, especially, you guessed it: Slicer3D.
Now the question, do we want this for SOFA as it might be useful in the future, or we don't ? I'll continue the Todo's once it has been decided.
The PR made on the plugins introduces an "environment.cmake" file for some of them, or used an existing one to fix out-of-tree compilation.
This can actually be breaking for all plugins where I didn't add this, so here is the todo list:
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/166]
[ci-depends-on https://github.com/sofa-framework/Sofa.Qt/pull/12]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/197]
[ci-depends-on https://github.com/sofa-framework/SofaGLFW/pull/206]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/334]
[ci-depends-on https://github.com/SofaDefrost/STLIB/pull/132]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/506]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/506]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if