Skip to content

[scripts] Fix recursive node parsing was forgetting root and add option to test if mechanicalObject is mapped #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
epernod wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[scripts] Fix recursive node parsing was forgetting root and add option to test if mechanicalObject is mapped #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7240b19
Add option to test if mechanicalObject is mapped and used it accordin…
epernod Jan 28, 2026
b59f22f
Fix parse_node regression method... IA is not perfect, I still have s…
epernod Jan 29, 2026
855a671
Fix test on is mapping
epernod Jan 29, 2026
a7c71d8
Fix wrong conversin of meca_in_mapping from string to bool
epernod Jan 29, 2026
55e989d
Merge branch 'master' into fix_nodeParsing
epernod Jan 30, 2026
b0b5693
Merge branch 'master' into fix_nodeParsing
epernod Feb 3, 2026
a923b1a
Update tools/RegressionSceneData.py
epernod Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions tools/RegressionSceneData.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ def default(self, obj):
return obj.tolist()
return JSONEncoder.default(self, obj)


def is_mapped(node):
Copy link
Contributor

@alxbilger alxbilger Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record, your test is based on an implicit rule that a mapped state is in the same Node than the mapping. But that's not mandatory...

Copy link
Contributor Author

@epernod epernod Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I guess there is no way from the MechanicalObject to know if it is mapped?
This means we should process all MechancalMapping first?

Copy link
Contributor

@alxbilger alxbilger Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You guessed right. But for now SOFA also relies on this in its visitors: https://github.com/sofa-framework/sofa/blob/694bc3cd2f3891460e3c69141095146f1198af61/Sofa/framework/Simulation/Core/src/sofa/simulation/BaseMechanicalVisitor.cpp#L79. You're safe for now.

Copy link
Contributor Author

@epernod epernod Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, anyway, this is mostly to match the old regression behavior. For me we should test all mechanicalObject, mapped or not.

mapping = node.getMechanicalMapping()

return mapping != None
# no mapping in this node context



class RegressionSceneData:
def __init__(self, file_scene_path: str = None, file_ref_path: str = None, steps = 1000,
Expand All @@ -77,7 +85,7 @@ def __init__(self, file_scene_path: str = None, file_ref_path: str = None, steps
self.file_ref_path = file_ref_path
self.steps = int(steps)
self.epsilon = float(epsilon)
self.meca_in_mapping = meca_in_mapping
self.meca_in_mapping = bool(meca_in_mapping)
self.dump_number_step = int(dump_number_step)
self.meca_objs = []
self.filenames = []
Expand Down Expand Up @@ -114,14 +122,18 @@ def print_meca_objs(self):


def parse_node(self, node, level = 0):
# first check current node
mstate = node.getMechanicalState()
if mstate and is_simulated(node):
if self.meca_in_mapping is True or is_mapped(node) is False:
self.meca_objs.append(mstate)
if self.verbose:
print(" " * level + f"- Adding MechanicalObject: {mstate.name.value} from Node: {node.name.value}")

# recursively check children
for child in node.children:
mstate = child.getMechanicalState()
if mstate:
if is_simulated(child):
self.meca_objs.append(mstate)

self.parse_node(child, level + 1)


def add_compare_state(self):
counter = 0
Expand Down
6 changes: 5 additions & 1 deletion tools/RegressionSceneList.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,12 @@ def process_file(self):
full_file_path = os.path.join(self.file_dir, values[0])
full_ref_file_path = os.path.join(self.ref_dir_path, values[0])

meca_in_mapping = False
if values[3] == '1': # converting string to Bool always gives True
meca_in_mapping = True

scene_data = RegressionSceneData.RegressionSceneData(full_file_path, full_ref_file_path,
values[1], values[2], values[3], values[4],
values[1], values[2], meca_in_mapping, values[4],
self.disable_progress_bar, self.verbose)

#scene_data.printInfo()
Expand Down