Add createdb support for sequence db input#545
Add createdb support for sequence db input#545matchy233 wants to merge 5 commits intosoedinglab:masterfrom
Conversation
| } | ||
|
|
||
| KSeqWrapper* kseq = NULL; | ||
| std::string seq = ">"; |
There was a problem hiding this comment.
Can we move this into the if condition?
There was a problem hiding this comment.
No we can't :( we need to refer to the address of this string later. Variables defined inside if {} block is not accessible to the outer scope.
|
I can modify |
|
This feature was meant for turning a bunch of fasta files in form of a DB (e.g., produced by If you want to consume sequence dbs and produce new sequence dbs, i would suggest to add a check for the presence of a header db and only then do your new code. |
|
Thanks for the explanation! I'll modify the code to support the old implementation as well as the new one. Maybe we can add the usage for database input to the usage text? so that some curious users (like me) would not get confused next time :P |
Add explanation about generic dbs
According to the source code of
createdb, it should be able to accept MMSeqs databases as one of the input sources. But the current implementation fail to handle MMSeqs db input. This PR fixes this issue.Probably need to edit
MMSeqsBase.cppwith new instructions.