Open
Conversation
|
Dear @htalibart, sorry for the very late reply, I somehow completely missed the notification. Thanks for reporting the issue! You are right, the def matrianglify_t(data, size=20):
""" Make a symmetric size * size matrix out of an array of triangle array data"""
mat = np.zeros((size, size))
mat[np.tril_indices(size)] = data
sym_mat = np.maximum(mat, mat.T)
return sym_mat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear all,
I noticed that the "matrianglify" function did not yield the correct output for the BLOSUM62 matrix given in the same file. It was a problem of indexes, so I rewrote the function. (I am not aware of a numpy function to do this so I used "for" loops, maybe there is a more optimal way to do it ?)
Hope this will be useful.