Skip to content

Conversation

@alansaul
Copy link
Collaborator

Adding ability to pass along the gradient function to use for Adadelta, necessary for doing stochastic gradients with GPy models.

@codecov-io
Copy link

codecov-io commented Nov 15, 2017

Codecov Report

Merging #24 into master will decrease coverage by 0.09%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #24     +/-   ##
=========================================
- Coverage   96.68%   96.59%   -0.1%     
=========================================
  Files          26       26             
  Lines        2084     2087      +3     
  Branches      332      333      +1     
=========================================
+ Hits         2015     2016      +1     
- Misses         55       56      +1     
- Partials       14       15      +1
Impacted Files Coverage Δ
paramz/optimization/optimization.py 98.4% <50%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1500072...3f60b6f. Read the comment docs.

@mzwiessele
Copy link
Member

Why is the coverage going down here? Do we have the ability to put a test in place, which tests the stochastic gradient function?

@mzwiessele
Copy link
Member

We need to put in the test case here! Then we can merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants