Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces Falcon::CompositeServer to manage and run multiple Falcon::Server instances within a single worker, along with tests and release notes.
Changes:
- Add
Falcon::CompositeServerto coordinate running multiple namedFalcon::Serverinstances and aggregate their statistics. - Add a focused test suite for
Falcon::CompositeServerto validate multi-endpoint handling, stopping behavior, and statistics output. - Wire the new class into the public
falconentrypoint and document the new feature inreleases.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/falcon/composite_server.rb | Implements Falcon::CompositeServer with run, statistics_string, and detailed_statistics to manage multiple server instances and expose per-server stats. |
| test/falcon/composite_server.rb | Provides tests covering multi-server management, request handling across endpoints, stopping behavior, and statistics for zero, one, and multiple servers. |
| lib/falcon.rb | Exposes Falcon::CompositeServer via the main falcon require, making it part of the public API. |
| releases.md | Notes the introduction of Falcon::CompositeServer in the unreleased changelog section. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
Falcon::CompositeServerfor hosting multiple server instances in a single worker.Types of Changes
Contribution