Conversation
adrianluisgonzalez
force-pushed
the
feature/acl_support
branch
from
d75e8a0 to
94f50d5
Compare
adrianluisgonzalez
force-pushed
the
feature/acl_support
branch
from
94f50d5 to
c439489
Compare
|
Any update on when this change will be merged? |
|
Would love to see this merged cc @xiaochuanyu |
|
Will try to test out this PR this weekend. |
|
@xiaochuanyu any luck? |
|
@simplesteph sorry I didn't have time last weekend. Will try to find some time for this. |
| .retryPolicy(new ExponentialBackoffRetry(1000, 3)); | ||
|
|
||
| String zkSuperUserPassword = configManager.getConfig().getString(StringConfigs.ZK_SUPER_USER_PASSWORD); | ||
| if (zkSuperUserPassword != null && !zkSuperUserPassword.equals("")) { |
There was a problem hiding this comment.
Style: !Strings.isNullOrEmpty(zkSuperUserPassword)
| /** | ||
| * Contains a list of all those properties that we don't want returned in the 'get-state' method. | ||
| */ | ||
| private static final List<StringConfigs> EXCLUSIONS = Arrays.asList( |
There was a problem hiding this comment.
Style:
private static final Set<StringConfigs> EXCLUSIONS = Sets.immutableEnumSet(
StringConfigs.ZK_SUPER_USER_PASSWORD
);
| try | ||
| { | ||
| List<ACL> acls = new ArrayList<ACL>(); | ||
| boolean processAcls = (aclsEnabled && (aclsJsonArray != null && !aclsJsonArray.equals(""))); |
There was a problem hiding this comment.
Style: !Strings.isNullOrEmpty(aclsJsonArray)
|
|
||
| for (ACL acl : acls) { | ||
| aclsAsString.append(encodeAclToString(acl)); | ||
| aclsAsString.append("<br/>"); |
There was a problem hiding this comment.
I don't think we should have html tags in return values of the REST API.
Maybe JSON list of strings?
| $("#stat").text(data.stat); | ||
| $("#data-bytes").text(data.bytes); | ||
| $("#data-str").text(data.str); | ||
| $("#node-acl").html(data.acls) |
There was a problem hiding this comment.
Assuming we want data.acl to be json list of strings.
This part will need to be changed to parse it into html.
|
Closing and re-opening to trigger Travis CI. |
5 participants
Added support for ACLs. ACL support is turned off by default in configuration. Also made the tracking fields possible to be turned off via configuration.