Skip to content

Release 4.6.4 #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
+16 −4
Merged

Release 4.6.4 #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...anges/@snowplow/browser-plugin-snowplow-ecommerce/ga4-ecommerce-fix_2025-05-28-10-25.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/browser-plugin-snowplow-ecommerce",
"comment": "Fixing GA4 Ecommerce functions to use finalCartValue within ecommerce object",
"type": "none"
}
],
"packageName": "@snowplow/browser-plugin-snowplow-ecommerce"
}
10 changes: 6 additions & 4 deletions plugins/browser-plugin-snowplow-ecommerce/src/ga4/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,23 @@ export function trackGA4SelectPromotion(ecommerce: GA4EcommerceObject & Promotio
}

export function trackGA4AddToCart(
ecommerce: GA4EcommerceObject & Currency,
ecommerce: GA4EcommerceObject & Currency & { finalCartValue?: number },
opts: Options & { finalCartValue: number }
) {
const currency = (ecommerce.currency || opts.currency)!;
const finalCartValue = ecommerce.finalCartValue ?? opts.finalCartValue;
const products = transformG4ItemsToSPProducts(ecommerce, currency);
trackAddToCart({ products, total_value: opts.finalCartValue, currency });
trackAddToCart({ products, total_value: finalCartValue, currency });
}

export function trackGA4RemoveFromCart(
ecommerce: GA4EcommerceObject & Currency,
ecommerce: GA4EcommerceObject & Currency & { finalCartValue?: number },
opts: Options & { finalCartValue: number }
) {
const currency = (ecommerce.currency || opts.currency)!;
const finalCartValue = ecommerce.finalCartValue ?? opts.finalCartValue;
const products = transformG4ItemsToSPProducts(ecommerce, currency);
trackRemoveFromCart({ products, total_value: opts.finalCartValue, currency });
trackRemoveFromCart({ products, total_value: finalCartValue, currency });
}

export function trackGA4ViewItem(ecommerce: GA4EcommerceObject, opts: Options = {}) {
Expand Down
Loading