Show PIN pad as default; Unlock screen with RFID (only for Cards & Colors themes)#2807
Open
Fluxxo wants to merge 11 commits intosnaptec:masterfrom
Open
Show PIN pad as default; Unlock screen with RFID (only for Cards & Colors themes)#2807Fluxxo wants to merge 11 commits intosnaptec:masterfrom
Fluxxo wants to merge 11 commits intosnaptec:masterfrom
Conversation
…re instantly after a successful code input.
fixing a bug where in the colors theme the tap on the loading point would raise an exception due to a change in the modeButtonClicked method signature
… to unlock if an rfid is assigned to a car or part of the rfid list when rfid modus=2
- implemented rfid screen unlock for the colors theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented some UX features I found handy in day2day handling of the OpenWB:
The themes "cards" and "colors" showed a modal dialog that a pin is required for unlocking. One would always need to hit the rather tiny lock icon to use a locked display to show the number pad. The changed behaviour is that the PIN pad displays by default whenever an action is used requiring an unlocked screen.
Additionally, the "success" feedback (flashing background in green) was reduced from 1000ms to 250ms, avoiding an unnecessary delay after successful input
The PIN pad will submit automatically after the fourth digit is entered, avoiding the need to tap the "enter" button, reducing necessary user interactions for quicker usage.
Users can now unlock the screen by presenting their RFID token. The screen locks automatically after the configured time. To achieve this: