Skip to content

Fix GitHub Actions #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
+82 −179
Open

Fix GitHub Actions #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
84cda10
initial github actions fixes
jonathan343 Oct 8, 2025
e3bb264
testing stuff
jonathan343 Oct 8, 2025
590ea00
fix matrix.python-version conditional
jonathan343 Oct 8, 2025
d30d268
test removing UV_SYSTEM_PYTHON
jonathan343 Oct 8, 2025
858ff95
test on ubuntu, windows, and macos
jonathan343 Oct 8, 2025
27c2c8e
upgrade aiohttp to use a version that supports 3.14
jonathan343 Oct 8, 2025
88e4963
actually run job on the os
jonathan343 Oct 8, 2025
caeb43e
Remove dependency on outdated docformatter package
jonathan343 Oct 8, 2025
b0f8c31
remove os matrix and commented lines
jonathan343 Oct 8, 2025
9a3479a
update branch from master to main
jonathan343 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,24 @@ on:
push:
branches:
- develop
- main

pull_request:
branches:
- develop

env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarifying question - this was the source of the issue, right? It would always use the system version instead of the one specified by the matrix?

UV_SYSTEM_PYTHON: true

jobs:
ci:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ["3.12", "3.13", "3.14-dev"]
python-version: ["3.12", "3.13", "3.14"]

steps:
- name: Checkout Repository
uses: actions/checkout@v5

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v6

- name: Set up JDK 17
uses: actions/setup-java@v5
with:
Expand All @@ -36,18 +31,19 @@ jobs:
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4

- name: Install uv
- name: Install uv and set the Python version
uses: astral-sh/setup-uv@v7
with:
python-version: ${{ matrix.python-version }}
activate-environment: true
enable-cache: true

- name: Setup workspace
run: |
export UV_PROJECT_ENVIRONMENT="${pythonLocation}"
echo "UV_PROJECT_ENVIRONMENT=$UV_PROJECT_ENVIRONMENT" >> "$GITHUB_ENV"
make install

- name: Check python packages
if: ${{ matrix.python-version == '3.12' }}
run: |
make check-py

Expand Down
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ lint-py: ## Runs linters and formatters on the python packages.


check-py: ## Runs checks (formatting, lints, type-checking) on the python packages.
uv run docformatter packages
uv run ruff check packages --config pyproject.toml
uv run ruff format --check --config pyproject.toml
uv run pyright packages
Expand Down
6 changes: 0 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ test = [
"freezegun>=1.5.1",
]
lint = [
"black>=25.1.0",
"ruff>=0.9.7",
"docformatter>=1.7.5",
]
typing = [
"pyright>=1.1.400",
Expand Down Expand Up @@ -50,10 +48,6 @@ asyncio_mode = "auto" # makes pytest run async tests without having to be marked
addopts = [ "--import-mode=importlib", "--cov", "--cov-report=term-missing" ]
consider_namespace_packages = true

[tool.docformatter]
recursive = true
black = true

[tool.ruff]
target-version = "py312"

Expand Down
Loading
Loading