Fix TypeError when collapse element is unmounted before transition completes #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition where the internal collapse element ref can become null between scheduling a requestAnimationFrame and its execution, or between starting a transition and receiving the transitionend event.
When this happens, the current implementation tries to access scrollHeight on a null element and throws:
TypeError: Cannot read properties of null (reading 'scrollHeight')
The fix adds null checks for collapseRef in the requestAnimationFrame callbacks and in the transitionend handler. If the element has been unmounted, the callbacks now bail out early, preserving the existing behavior without throwing.
Screenshots from Sentry:
Lines caused error in our app:
