build: update golang.org/x/tools to v0.42.0 for Go 1.25+ compatibility#703
Open
vdemeester wants to merge 1 commit intosmartystreets:masterfrom
Open
build: update golang.org/x/tools to v0.42.0 for Go 1.25+ compatibility#703vdemeester wants to merge 1 commit intosmartystreets:masterfrom
vdemeester wants to merge 1 commit intosmartystreets:masterfrom
Conversation
The vendored golang.org/x/tools v0.18.0 uses unsafe struct punching into token.FileSet internals that breaks with Go 1.25+ due to token.FileSet layout changes. This updates to golang.org/x/tools v0.42.0 which uses the native FileSet.AddExistingFiles method available since Go 1.25. Fixes build errors with Go 1.25+: vendor/golang.org/x/tools/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta * delta (constant -256 of type int64) Reference: https://go-review.googlesource.com/c/tools/+/672618
vdemeester
added a commit
to vdemeester/nixpkgs
that referenced
this pull request
Feb 16, 2026
Update golang.org/x/tools dependency to v0.42.0 via upstream patch. The vendored golang.org/x/tools v0.18.0 uses unsafe struct punching into token.FileSet internals that breaks with Go 1.25+ due to token.FileSet layout changes. Upstream PR: smartystreets/goconvey#703 Fixes: NixOS#490142 (comment)
13 tasks
vdemeester
added a commit
to vdemeester/nixpkgs
that referenced
this pull request
Feb 17, 2026
Update golang.org/x/tools dependency to v0.42.0 via upstream patch. The vendored golang.org/x/tools v0.18.0 uses unsafe struct punching into token.FileSet internals that breaks with Go 1.25+ due to token.FileSet layout changes. Upstream PR: smartystreets/goconvey#703 Fixes: NixOS#490142 (comment)
vdemeester
added a commit
to vdemeester/nixpkgs
that referenced
this pull request
Feb 17, 2026
Update golang.org/x/tools dependency to v0.42.0 via upstream patch. The vendored golang.org/x/tools v0.18.0 uses unsafe struct punching into token.FileSet internals that breaks with Go 1.25+ due to token.FileSet layout changes. Upstream PR: smartystreets/goconvey#703 Fixes: NixOS#490142 (comment)
orzklv
pushed a commit
to xinux-org/nixpkgs
that referenced
this pull request
Feb 17, 2026
Update golang.org/x/tools dependency to v0.42.0 via upstream patch. The vendored golang.org/x/tools v0.18.0 uses unsafe struct punching into token.FileSet internals that breaks with Go 1.25+ due to token.FileSet layout changes. Upstream PR: smartystreets/goconvey#703 Fixes: NixOS#490142 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored golang.org/x/tools v0.18.0 uses unsafe struct punching into token.FileSet internals that breaks with Go 1.25+ due to token.FileSet layout changes.
This updates to golang.org/x/tools v0.42.0 which uses the native FileSet.AddExistingFiles method available since Go 1.25.
Fixes build errors with Go 1.25+:
Reference: https://go-review.googlesource.com/c/tools/+/672618
Testing:
This change is needed for NixOS/nixpkgs#490992