fix(txm): delete nonceBroadcastCounts on tx confirmation - #698
Closed
cawthorne wants to merge 1 commit into
Closed
Conversation
nonceBroadcastCounts entries were only removed on nonce resync, not when transactions confirmed normally, causing unbounded sync.Map growth over the lifetime of OCR transmitter nodes.
|
👋 cawthorne, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
cawthorne
marked this pull request as draft
June 19, 2026 12:21
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonceBroadcastCountsentries in the TXM confirm loop when a transaction is confirmedbroadcastTimeson the same pathProblem
nonceBroadcastCountswas populated on every broadcast but only deleted during nonce resync/stale-tx handling. On a normal OCR transmitter node, one map entry accumulated per confirmed transmission for the process lifetime.Introduced in chainlink-starknet #655 (merged 2025-11-28); first shipped in chainlink core via plugin bump #20490 (2025-12-03, ref
0051d73c).Test plan
go test ./relayer/pkg/chainlink/txm/...plugins.public.yamlstarknet ref when ready