feat(macos): registry edit/remove + drop warnings; official read-only (MCP-1074) - #596
Merged
Merged
Conversation
… (MCP-1074)
Provenance is informational only (MCP-1072), so the macOS tray no longer shows
the "third-party · unverified / always quarantined" warnings. Replace them with
a neutral Official / Custom badge (shared RegistryProvenanceBadge).
Add a Configured-registries management list to RegistriesView (custom rows
first, so the actionable ones lead): each custom registry gets a trailing
ellipsis menu and a right-click context menu offering Edit Registry… (a
pre-filled AddRegistryView edit sheet that PUTs /api/v1/registries/{id}, id
immutable) and Remove Registry… (a destructive confirmationDialog that DELETEs
it). Official/built-in registries are read-only with a checkmark.seal indicator
and no menu.
Add APIClient.editRegistrySource / removeRegistrySource, move the provenance
model to the 2-value official/custom scheme (legacy official/trusted |
custom/unverified still accepted on read), and drop the obsolete one-time
third-party warning + ThirdPartyRegistryAck.
Related MCP-1074
Deploying mcpproxy-docs with
|
| Latest commit: |
7b6ebe3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://51769cd4.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://mcp-1074-macos-registry-edit.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 26951096478 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (MCP-1074 — v0.37.0 blocker)
macOS tray registry surface, updated for the MCP-1072 provenance simplification (provenance is now informational only — servers follow the global quarantine default).
Warnings removed
RegistriesViewand the "always quarantined / cannot skip security review" note inServerBrowseView's registry-info popup.Third-party · unverified/Official · trustedstyling with a neutral Official / Custom badge (RegistryProvenanceBadge, reused by the browse info popup).ThirdPartyRegistryAck.Edit + Remove (macOS HIG)
RegistriesView(custom rows first, so the actionable ones lead).ellipsis.circle) and a right-click.contextMenu, both offering:.sheetreusingAddRegistryViewin edit mode (pre-filled name/url, id immutable) →PUT /api/v1/registries/{id}.role: .destructive) → a.confirmationDialognaming the registry →DELETE /api/v1/registries/{id}.checkmark.sealindicator.APIClient.editRegistrySource/removeRegistrySource; provenance model moved to the 2-valueofficial/customscheme (legacyofficial/trusted|custom/unverifiedstill accepted on read).Verification
swift build -c releasegreen;MCPProxyTests/RegistryModelsTests19/19 pass (new tests for the 2-value + legacy provenance and theregistry_not_foundedit-error mapping). Remaining full-suite failures (SSEParser/Models/AutoStart/MergePatch) are pre-existing and unrelated — they fail identically onorigin/main.Officialbadge + seal, custom rows show the ellipsis menu → Edit Registry… / Remove Registry…, the edit sheet opens pre-filled (immutable id), and the client issues the correctPUT(the live core's older build lacks the route, so it surfaced the mapped error — confirming the request path + error handling).POST→PUT(rename + new url, provenancecustom)→GET→DELETE→GETall return 200 / behave correctly.Related MCP-1074