-
Notifications
You must be signed in to change notification settings - Fork 3
Extend schemas for Dataset and DataService from 2.1.1 to 3.0.0 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
flopezag
commented
Oct 15, 2024
- Aligned to 3.0.0
- Correct some issues with the specification of DCAT-AP to transform links to Relationship
- Fix the license values available
- Update notes.yaml and README.md
…ions (WATERVERSE)
albertoabellagarcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feernando. please check the comments sent internally
|
Hi, What's the status of this PR? May I help in some way (since I'm working on this with @flopezag in the WATERVERSE project)? |
…el.DCAT-AP into extend_schemas
albertoabellagarcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attend the changes requested and pass the validator
albertoabellagarcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have sent you the comment directly there are a couple of issues on both data models dataservice and dataservicerun
albertoabellagarcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have to test if our testing process can deal with languageproperties
I suggest checking it in the new service deployed on fair-services.lab.fiware.org for DataService and Dataset. |
…logueRecord, DataServiceRune, and Distribution
albertoabellagarcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes are required, couple of errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is wrong (page 33 of the specification)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compression format property is represented by dcat:compressFormat in DCAT. I used the last one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong change packageFormat not packagingFormat (page 18 specification), same for compressionFormat. Rest of changes are ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem to compressionFormat. packaging format property is represented in dcat:packageFormat in DCAT.