feat: add properties to DataService data model #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertoabellagarcia
requested changes
Jun 24, 2025
Contributor
albertoabellagarcia
left a comment
albertoabellagarcia
left a comment
There was a problem hiding this comment.
address the comment, and do not work on automatically generated files.
* Renamed `endPointURL` to `endpointURL` * Renamed `endPointDescription` to `endpointDescription` * Added `disseminationOrganisation`, `dissemination`, `reputationOrganisation`, `reputation` and `accessMechanism` (from Meloda5 metrics) * Added `imageSource` * Added `versionNotes`
bobeal
force-pushed
the
feature/add-data-services-properties
branch
from
e46c6dd to
b133b38
Compare
Author
|
OK removed all the generated files from the PR. |
Author
|
@albertoabellagarcia is everything now OK with the PR? |
Contributor
|
the data service has an issue the version is published as 1.0 (number) but defined in the schema as string |
Author
Fixed. I changed the value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endPointURLtoendpointURLendPointDescriptiontoendpointDescriptiondisseminationOrganisation,dissemination,reputationOrganisation,reputationandaccessMechanism(from Meloda5 metrics)imageSourceversionNotes