Use crypto:strong_rand_bytes/1 instead of crypto:rand_bytes/1#19
Open
benjamin-bergia wants to merge 1 commit intosmarkets:masterfrom
benjamin-bergia:master
Open
Use crypto:strong_rand_bytes/1 instead of crypto:rand_bytes/1#19benjamin-bergia wants to merge 1 commit intosmarkets:masterfrom benjamin-bergia:master
benjamin-bergia wants to merge 1 commit intosmarkets:masterfrom
benjamin-bergia:master
Conversation
|
I have a patch which checks for erlang version at https://github.com/lafka/erlang-bcrypt/tree/lafka-erlang19-rand-bytes if interesting |
|
Merged into https://github.com/erlangpack/bcrypt and published to Hex.pm as bcrypt 1.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto:rand_bytes/1has been deprecated in newer versions of erlang. This PR replace the calls tocrypto:rand_bytes/1withcrypto:strong_rand_bytes/1.This will probably break the compatibility with older versions of Erlang. If needed I can update this PR to favor
crypto:strong_rand_bytes/1and, if not available, fallback oncrypto:rand_bytes/1.Also from the doc,
crypto:strong_rand_bytes/1can throw alow_entropyexception. I have far from an expert in this field, so if you have any comment or recommendation, please let me know.