fix: suppress and resolve console warnings#532
Open
takaokouji wants to merge 2 commits intodevelopfrom
Open
Conversation
- Added src/lib/log-suppression.js to filter out specific console warnings. - Imported suppression logic in main playground entry point and library index. - Warnings suppressed include: - Object freezing is not supported by Opal - Canvas2D willReadFrequently attribute - React defaultProps deprecation (future-proofing) - React unknown prop recognition - Deprecated React lifecycle methods - findDOMNode deprecation - AudioContext user gesture requirement - apple-mobile-web-app-capable meta tag deprecation 🤖 Generated with [Gemini Code](https://gemini.google.com/code) Co-Authored-By: Gemini <noreply@google.com>
- Improve log-suppression to check all console arguments - Add GenerateSW warning to ignoredWarnings - Add mobile-web-app-capable meta tag to address deprecation warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several console warnings that appeared when running the GUI in development mode.
Implementation details
src/lib/log-suppression.jsto check all arguments passed toconsole.warnandconsole.error. This ensures that formatted React warnings are correctly identified and suppressed. AddedGenerateSW has been called multiple timesto ignored warnings as well.<meta name="mobile-web-app-capable" content="yes">tosrc/playground/index.ejsto resolve the deprecation warning forapple-mobile-web-app-capable.log-suppression.js.Test coverage
Co-Authored-By: Gemini noreply@google.com