feat(provider): route openai/resp_api to the Responses driver - #551
Merged
Conversation
ResolveProvider now normalizes --protocol once and switches on the canonical selector: openai/openai/chat build the Chat Completions driver, openai/resp_api builds the Responses driver, both requiring an explicit --base-url. anthropic and the model-id heuristics are unchanged. resp_api with no base-url errors, mirroring the openai rule.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResolveProvidernormalizes--protocolviaNormalizeProtocoland switches on the canonical selector.openaiandopenai/chatbuild the existing Chat Completions driver (both require--base-url).openai/resp_apibuilds the Responses driver (NewOpenAIResponsesProvider) against--base-url; empty base-url errors, mirroring theopenairule (Open Question resolved: option B, no public default endpoint).anthropic,--provider <name>, and model-id heuristics are unchanged.Closes #543
Test plan
go build ./...go vet ./internal/provider/go test ./internal/provider/(new TestResolveProviderResponsesProtocol + unchanged chat/anthropic/provider paths)gofmt -lclean