Skip to content

Conversation

@ikovic
Copy link
Collaborator

@ikovic ikovic commented Apr 1, 2025

Description

Previous PR had the @slashid/slash module being included in the bundle while it is supposed to be external.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have generated the new version of the docs website and smoke tested it
  • I have checked that my changes haven't caused semantic errors in the existing docs
  • I have generated a changeset if my change affects the published packages

@ikovic ikovic requested a review from jake-slashid April 1, 2025 14:30
@ikovic ikovic self-assigned this Apr 1, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 1, 2025

Deploying website-react-storybook with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9beac19
Status: ✅  Deploy successful!
Preview URL: https://66d22a4d.website-react-storybook.pages.dev
Branch Preview URL: https://sid-update-fix-sdk-being-inc.website-react-storybook.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Bundle size comparison

Name +/- Base Current +/- gzip Base gzip Current gzip
main.js -39.47% 644.88 kB 390.34 kB -33.12% 153.60 kB 102.73 kB
style.css = 38.27 kB 38.27 kB = 6.50 kB 6.50 kB
main.d.ts = 5.63 kB 5.63 kB = 1.39 kB 1.39 kB

Generated by 🚫 dangerJS against 9beac19

@ikovic ikovic merged commit 8bf5b15 into main Apr 1, 2025
5 checks passed
@ikovic ikovic deleted the sid-update-fix-sdk-being-included branch April 1, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants