Skip to content

Conversation

@ikovic
Copy link
Collaborator

@ikovic ikovic commented Feb 6, 2025

Description

The BE normalises the email address value before validating it. We use the same regex, but the FE did not perform normalization. Now we lowercase all the characters before validating, removing false positives.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have generated the new version of the docs website and smoke tested it
  • I have checked that my changes haven't caused semantic errors in the existing docs
  • I have generated a changeset if my change affects the published packages

@ikovic ikovic requested a review from kaspermroz February 6, 2025 07:27
@ikovic ikovic self-assigned this Feb 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Bundle size comparison

Name +/- Base Current +/- gzip Base gzip Current gzip
main.js +0.00% 409.14 kB 409.16 kB +0.01% 107.45 kB 107.46 kB
style.css = 38.27 kB 38.27 kB = 6.50 kB 6.50 kB
main.d.ts = 4.73 kB 4.73 kB = 1.15 kB 1.15 kB

Generated by 🚫 dangerJS against c253c4c

@ikovic ikovic merged commit 0029745 into main Feb 6, 2025
5 checks passed
@ikovic ikovic deleted the sid-fix-gh-email-validation branch February 6, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants