[HRD-Console] React SDK implementation #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying website-react-storybook with
|
| Latest commit: |
1220cb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ba33c69.website-react-storybook.pages.dev |
| Branch Preview URL: | https://console-hrd-react-sdk.website-react-storybook.pages.dev |
kaspermroz
commented
Jan 13, 2025
Contributor
ikovic
reviewed
Jan 17, 2025
packages/react/src/components/form/org-switching/org-switching-form.tsx
Outdated
Show resolved
Hide resolved
ikovic
reviewed
Jan 17, 2025
packages/react/src/components/form/org-switching/org-switching-form.tsx
Outdated
Show resolved
Hide resolved
ikovic
reviewed
Jan 17, 2025
ikovic
reviewed
Jan 17, 2025
packages/react/src/components/form/org-switching/useOrgSwitchingFlowState.ts
Outdated
Show resolved
Hide resolved
ikovic
reviewed
Jan 17, 2025
packages/react/src/components/form/org-switching/org-switching-form.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
@kaspermroz can you add a test suite for this flow? Ideally one case for the path when authentication is not required and one with authentication. I think you could potentially do it without mocking any network requests as it is possible to mock the core SDK so we could do it at that level 🤔 |
ikovic
reviewed
Jan 17, 2025
packages/react/src/components/form/org-switching/org-switching-flow.ts
Outdated
Show resolved
Hide resolved
ikovic
reviewed
Feb 5, 2025
ikovic
reviewed
Feb 5, 2025
ikovic
reviewed
Feb 5, 2025
ikovic
reviewed
Feb 5, 2025
ikovic
reviewed
Feb 5, 2025
Collaborator
|
@kaspermroz I think this is on track with what we discussed, can you release a beta and see how this works when used in the console? |
kaspermroz
commented
Feb 6, 2025
packages/react/src/components/form/org-switching/useOrgSwitchingFlowState.ts
Show resolved
Hide resolved
ikovic
reviewed
Feb 10, 2025
packages/react/src/components/form/org-switching/org-switching-flow.ts
Outdated
Show resolved
Hide resolved
ikovic
reviewed
Feb 10, 2025
packages/react/src/components/form/org-switching/org-switching-flow.ts
Outdated
Show resolved
Hide resolved
ikovic
reviewed
Feb 10, 2025
packages/react/src/components/form/org-switching/org-switching-flow.ts
Outdated
Show resolved
Hide resolved
ikovic
reviewed
Feb 10, 2025
ikovic
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR:
__orgSwitchingState<OrgSwitchingForm>Checklist
changesetif my change affects the published packages