Skip to content

Conversation

@ikovic
Copy link
Collaborator

@ikovic ikovic commented Jan 7, 2025

Description

YouTrack issue

When the last subscriber of an event type would unsubscribe, the event buffer was supposed to buffer any future instances of this event type and replay them to the first subscriber. Due to a bad state check this wouldn't happen if you had already subscribed to this event type, unsubscribed and then subscribed again.

This issue is now fixed and a unit test was added that confirms this.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have generated the new version of the docs website and smoke tested it
  • I have checked that my changes haven't caused semantic errors in the existing docs
  • I have generated a changeset if my change affects the published packages

@ikovic ikovic requested a review from kaspermroz January 7, 2025 17:10
@ikovic ikovic self-assigned this Jan 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Bundle size comparison

Name +/- Base Current +/- gzip Base gzip Current gzip
main.js +0.03% 409.04 kB 409.14 kB +0.04% 107.41 kB 107.45 kB
style.css = 38.27 kB 38.27 kB = 6.50 kB 6.50 kB
main.d.ts = 4.73 kB 4.73 kB = 1.15 kB 1.15 kB

Generated by 🚫 dangerJS against b5b8852

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying website-react-storybook with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5b8852
Status: ✅  Deploy successful!
Preview URL: https://6ab043c8.website-react-storybook.pages.dev
Branch Preview URL: https://sid-2056-back-button-block.website-react-storybook.pages.dev

View logs

@kaspermroz kaspermroz merged commit 9554f25 into main Jan 8, 2025
5 checks passed
@kaspermroz kaspermroz deleted the sid-2056-back-button-block branch January 8, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants