Inline vitess-addons and remove private repo access scaffolding#868
Draft
sbaker617 wants to merge 6 commits into
Draft
Inline vitess-addons and remove private repo access scaffolding#868sbaker617 wants to merge 6 commits into
sbaker617 wants to merge 6 commits into
Conversation
Copy go/durability and go/external packages from vitess-addons into this repo, update the shim import path, and remove the private module dependency. This eliminates the need for GH_ACCESS_TOKEN to fetch the private vitess-addons repo. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
Now that vitess-addons is inlined, there's no need for private repo access scaffolding. Remove all GH_ACCESS_TOKEN build args, GOPRIVATE env vars, and git config URL rewriting from Dockerfiles, build scripts, CI workflows, and the workflow generator. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
These conditional blocks were Slack-specific additions not present in upstream v22.0.4. Now that vitess-addons is inlined and goPrivate is unused, remove the dead template conditionals and GoPrivate struct fields from the workflow generator. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## slack-22.0 #868 +/- ##
==============================================
- Coverage 69.52% 69.51% -0.01%
==============================================
Files 1606 1608 +2
Lines 214357 214461 +104
==============================================
+ Hits 149021 149086 +65
- Misses 65336 65375 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The removal of GOPRIVATE/GH_ACCESS_TOKEN left empty env: mappings and empty with: blocks that are invalid YAML, causing GitHub Actions to fail to parse the workflow files. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
The upgrade/downgrade tests check out an older release that still has vitess-addons in its go.mod. Since we no longer have auth to the private repo, use go mod edit -droprequire to strip the dep before downloading. Also fixes empty env: and with: blocks from previous cleanup. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> Signed-off-by: Steve Baker <s.baker@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this?
Brings the vitess-addons code (durability policy + vtops external binary wrapper) directly into this repo and removes all the GH_ACCESS_TOKEN / GOPRIVATE plumbing that was needed to access the private dependency.
How it works
Commit 1: Copies
go/durability/andgo/external/from vitess-addons, updates the shim import, removes the module dependency.Commit 2: Strips GH_ACCESS_TOKEN from Dockerfiles, build scripts, CI workflows, and the workflow generator. Regenerates all CI workflow YAMLs.
Testing
go build ./...passesgo test ./go/durability/... ./go/external/... ./go/vt/vtctl/reparentutil/policy/...all passMost of this was written by Claude Code - I just provided direction.