Skip to content

PHP 8.4 compatibility for /src/Pecee/SimpleRouter/SimpleRouter.php #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: v5-development
Choose a base branch
from
Open

PHP 8.4 compatibility for /src/Pecee/SimpleRouter/SimpleRouter.php #724

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e22ea70
Merge pull request #686 from skipperbent/v5-development
skipperbent Nov 21, 2023
fd0237e
Merge pull request #687 from skipperbent/v5-release
skipperbent Nov 21, 2023
36dda20
Merge pull request #688 from skipperbent/v5-development
skipperbent Nov 21, 2023
ca053a6
Merge pull request #689 from skipperbent/v5-release
skipperbent Nov 21, 2023
ef4756c
Merge pull request #690 from skipperbent/v5-development
skipperbent Nov 27, 2023
3c03f08
Merge pull request #692 from skipperbent/v5-development
skipperbent Nov 27, 2023
b23f6a0
Merge pull request #691 from skipperbent/v5-release
skipperbent Nov 27, 2023
d75af21
Merge pull request #693 from skipperbent/v5-development
skipperbent Nov 27, 2023
fdbd72c
Merge pull request #694 from skipperbent/v5-release
skipperbent Nov 27, 2023
14c2199
Merge pull request #695 from skipperbent/v5-development
skipperbent Nov 27, 2023
0b01aa9
Merge pull request #698 from skipperbent/v5-development
skipperbent Nov 29, 2023
2a21524
Merge pull request #699 from skipperbent/v5-development
skipperbent Dec 9, 2023
8923bee
Merge pull request #700 from skipperbent/v5-development
skipperbent Dec 9, 2023
7098f6a
Merge pull request #696 from skipperbent/v5-release
skipperbent Dec 9, 2023
a2843d5
Merge pull request #702 from skipperbent/v5-development
skipperbent Dec 11, 2023
b98d40b
Merge pull request #703 from skipperbent/v5-release
skipperbent Dec 11, 2023
51f0659
PHP 8.4 compatibility for /src/Pecee/SimpleRouter/SimpleRouter.php
dariodelogu Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/Pecee/SimpleRouter/SimpleRouter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public static function redirect(string $where, string $to, int $httpCode = 301):
*
* @return RouteUrl|IRoute
*/
public static function get(string $url, $callback, array $settings = null): IRoute
public static function get(string $url, $callback, array|null $settings = null): IRoute
{
return static::match([Request::REQUEST_TYPE_GET], $url, $callback, $settings);
}
Expand All @@ -201,7 +201,7 @@ public static function get(string $url, $callback, array $settings = null): IRou
* @param array|null $settings
* @return RouteUrl|IRoute
*/
public static function post(string $url, $callback, array $settings = null): IRoute
public static function post(string $url, $callback, array|null $settings = null): IRoute
{
return static::match([Request::REQUEST_TYPE_POST], $url, $callback, $settings);
}
Expand All @@ -214,7 +214,7 @@ public static function post(string $url, $callback, array $settings = null): IRo
* @param array|null $settings
* @return RouteUrl|IRoute
*/
public static function put(string $url, $callback, array $settings = null): IRoute
public static function put(string $url, $callback, array|null $settings = null): IRoute
{
return static::match([Request::REQUEST_TYPE_PUT], $url, $callback, $settings);
}
Expand All @@ -227,7 +227,7 @@ public static function put(string $url, $callback, array $settings = null): IRou
* @param array|null $settings
* @return RouteUrl|IRoute
*/
public static function patch(string $url, $callback, array $settings = null): IRoute
public static function patch(string $url, $callback, array|null $settings = null): IRoute
{
return static::match([Request::REQUEST_TYPE_PATCH], $url, $callback, $settings);
}
Expand All @@ -240,7 +240,7 @@ public static function patch(string $url, $callback, array $settings = null): IR
* @param array|null $settings
* @return RouteUrl|IRoute
*/
public static function options(string $url, $callback, array $settings = null): IRoute
public static function options(string $url, $callback, array|null $settings = null): IRoute
{
return static::match([Request::REQUEST_TYPE_OPTIONS], $url, $callback, $settings);
}
Expand All @@ -253,7 +253,7 @@ public static function options(string $url, $callback, array $settings = null):
* @param array|null $settings
* @return RouteUrl|IRoute
*/
public static function delete(string $url, $callback, array $settings = null): IRoute
public static function delete(string $url, $callback, array|null $settings = null): IRoute
{
return static::match([Request::REQUEST_TYPE_DELETE], $url, $callback, $settings);
}
Expand Down Expand Up @@ -309,7 +309,7 @@ public static function partialGroup(string $url, Closure $callback, array $setti
* @return RouteUrl|IRoute
* @see SimpleRouter::form
*/
public static function basic(string $url, $callback, array $settings = null): IRoute
public static function basic(string $url, $callback, array|null $settings = null): IRoute
{
return static::form($url, $callback, $settings);
}
Expand All @@ -324,7 +324,7 @@ public static function basic(string $url, $callback, array $settings = null): IR
* @return RouteUrl|IRoute
* @see SimpleRouter::form
*/
public static function form(string $url, $callback, array $settings = null): IRoute
public static function form(string $url, $callback, array|null $settings = null): IRoute
{
return static::match([
Request::REQUEST_TYPE_GET,
Expand All @@ -341,7 +341,7 @@ public static function form(string $url, $callback, array $settings = null): IRo
* @param array|null $settings
* @return RouteUrl|IRoute
*/
public static function match(array $requestMethods, string $url, $callback, array $settings = null): IRoute
public static function match(array $requestMethods, string $url, $callback, array|null $settings = null): IRoute
{
$route = new RouteUrl($url, $callback);
$route->setRequestMethods($requestMethods);
Expand All @@ -361,7 +361,7 @@ public static function match(array $requestMethods, string $url, $callback, arra
* @param array|null $settings
* @return RouteUrl|IRoute
*/
public static function all(string $url, $callback, array $settings = null): IRoute
public static function all(string $url, $callback, array|null $settings = null): IRoute
{
$route = new RouteUrl($url, $callback);

Expand All @@ -380,7 +380,7 @@ public static function all(string $url, $callback, array $settings = null): IRou
* @param array|null $settings
* @return RouteController|IRoute
*/
public static function controller(string $url, string $controller, array $settings = null): IRoute
public static function controller(string $url, string $controller, array|null $settings = null): IRoute
{
$route = new RouteController($url, $controller);

Expand All @@ -399,7 +399,7 @@ public static function controller(string $url, string $controller, array $settin
* @param array|null $settings
* @return RouteResource|IRoute
*/
public static function resource(string $url, string $controller, array $settings = null): IRoute
public static function resource(string $url, string $controller, array|null $settings = null): IRoute
{
$route = new RouteResource($url, $controller);

Expand Down