This repository was archived by the owner on May 19, 2025. It is now read-only.
Skipper-go Solidity Contract Gas Optimization #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim380
commented
Apr 10, 2023
| uint256 fee; | ||
| } | ||
|
|
||
| // --------------------- Errors -------------------- // |
| address fromToken, | ||
| uint256 fromAmount, | ||
| DexHop[] memory route | ||
| DexHop[] calldata route |
Author
There was a problem hiding this comment.
route is not mutated in the function body so using calldata would save some gas.
| // Loop through the route and execute the trades | ||
| for (uint256 i = 0; i < route.length; i++) { | ||
| DexHop memory hop = route[i]; | ||
| uint256 length = route.length; |
Author
There was a problem hiding this comment.
Caching array length to avoid repeatedly loading from the state in each iteration.
Comment on lines
+126
to
+127
| (bool success, ) = owner().call{value: balance}(""); | ||
| if (!success) revert WithdrawNativeBalanceFailed(); |
Author
There was a problem hiding this comment.
.transfer has a hardcoded 2300 gas limit which prevents smart contracts from doing things like sending ether to a gnosis safe due to out of gas. .call instead forwards all gas and is now the recommended way to send ether from a contract. It's also reentrancy safe here since the function is only accessible by the owner.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few gas optimizations that I nitpicked while checking out the codebase: