Skip to content

[SE-349] Skip Go Registry Docs. Guide to PR: Override asset metadata from external registry #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: staging
Choose a base branch
from
Open

[SE-349] Skip Go Registry Docs. Guide to PR: Override asset metadata from external registry #1692

wants to merge 12 commits into from

Conversation

@Totalspud
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0dd105e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
skip-go-explorer-ddru Ready Ready Preview Comment Oct 28, 2025 3:06pm
skip-go-widget Ready Ready Preview Comment Oct 28, 2025 3:06pm

@Totalspud
Update asset registry override documentation
76f148d 
Refine documentation for clarity and accuracy:
- Simplify descriptions and remove redundant information
- Update logo size requirements and formatting guidelines
- Clarify when to include optional metadata fields
- Streamline PR submission process and branch naming
- Remove best practices section to reduce redundancy
- Improve examples for different asset types
@Totalspud
Improve asset registry documentation clarity
be89ea8 
- Add decimal display issues to common problems
- Fix typo: 'you assets' to 'your assets'
- Update section title to be more descriptive
- Use more relevant chain ID examples (Arbitrum, CosmosHub)
- Update review timeline: 3-5 days to 1-3 days
- Simplify support section formatting
@Totalspud
Add logo size maximum and ignore nul file
abadd29 
- Specify maximum logo size (800x800px) for PNG files
- Add nul to .gitignore to prevent Windows reserved filename issues
@Totalspud Totalspud changed the title Asset images Skip Go Registry [SE-349] Skip Go Registry Docs. Guide to PR: Override asset metadata from external registry Oct 22, 2025
@linear
Copy link

linear bot commented Oct 22, 2025

SE-349 Documentation clarity for Skip’s image and registry setup

@Totalspud Totalspud marked this pull request as ready for review October 22, 2025 12:23
cursor[bot]

This comment was marked as outdated.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@codingki codingki Awaiting requested review from codingki codingki is a code owner

@NotJeremyLiu NotJeremyLiu Awaiting requested review from NotJeremyLiu NotJeremyLiu is a code owner

@toddkao toddkao Awaiting requested review from toddkao toddkao is a code owner

@ericHgorski ericHgorski Awaiting requested review from ericHgorski ericHgorski is a code owner

@daps94 daps94 Awaiting requested review from daps94 daps94 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Totalspud