fix(devcontainer): remove duplicate keys and invalid setting in VS Code config#39
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/skills/create-applications-with-the-copilot-cli/sessions/473b6ab6-017a-4577-af6c-3de341b4f1ac Co-authored-by: arilivigni <4140343+arilivigni@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
arilivigni
April 6, 2026 00:47
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up the devcontainer’s VS Code settings to avoid silently ignored configuration caused by duplicate JSON keys and an invalid “setting” entry, ensuring the intended editor/terminal behavior is applied consistently in the devcontainer environment.
Changes:
- Removed duplicate
workbench.startupEditorandworkbench.panel.opensMaximizedkeys from.devcontainer/devcontainer.json. - Removed invalid
workbench.action.terminal.focusentry (command ID, not a setting). - Kept terminal-in-editor-area configuration (
terminal.integrated.defaultLocation,terminal.integrated.showOnStartup) intact.
Show a summary per file
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Deduplicates VS Code settings and removes an invalid config key so devcontainer settings aren’t shadowed/ignored. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Collaborator
|
@copilot are these settings set in the devcontainer config |
Contributor
Author
Yes, both settings are present in the devcontainer config:
Together these ensure the terminal opens in the editor area automatically on container startup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The devcontainer VS Code settings block contained duplicate JSON keys (
workbench.startupEditor,workbench.panel.opensMaximized) and an invalid entry (workbench.action.terminal.focus, which is a command ID, not a setting) — all silently ignored or shadowed at runtime.Changes
workbench.startupEditor(was defined twice, both"none")workbench.panel.opensMaximized(was defined twice, both"always")workbench.action.terminal.focus: true— not a valid VS Code settingThe two settings that configure terminal-in-editor-area behavior were already correct and are preserved: