Ensure CLI output reflects active executable (skale/mirage)#862
Closed
Masterix0 wants to merge 2 commits into
Closed
Ensure CLI output reflects active executable (skale/mirage)#862Masterix0 wants to merge 2 commits into
skale/mirage)#862Masterix0 wants to merge 2 commits into
Conversation
…ddition. Also fixed some failing tests related to previous changes.
Masterix0
requested review from
badrogger,
dmytrotkk and
kladkogex
as code owners
Masterix0
changed the title
skale/mirage)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
User-facing messages in
node-clipreviously hardcoded "skale" as the executable, leading to incorrect command suggestions formiragebinary users.Solution
Updated CLI output logic to dynamically display the correct executable name (
skaleormirage) based on the currentNodeType. This involves:text.ymlfor Mirage-specific message variants.This change improves user experience by providing accurate command examples tailored to the active binary.