Chat correctness pass: attachment-only quotes, honest channel previews, non-occluding attachment viewer - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and display of attachment-only messages in chat, ensuring that messages with only attachments (and no text) are clearly labeled throughout the mobile and web UIs. It also ensures that channel previews update correctly when posts are edited or deleted, and refines the attachment viewer's UI so that controls never obscure the content.
Attachment-only message support and display:
quotedBodyText(and helperattachmentOnlyLabel) informatting.tsto generate a user-friendly label (e.g., "Attachment" or "2 attachments") for messages that have no text but do have attachments, ensuring quoted messages and reply banners are never blank or misleading.chats/[channelId].tsx) and message bubble (message-bubble.tsx) to usequotedBodyText, and passed the newattachment_countfield through the relevant data structures and UI components. (apps/mobile/src/app/(tabs)/chats/[channelId].tsxR68, apps/mobile/src/app/(tabs)/chats/[channelId].tsxR663, apps/mobile/src/app/(tabs)/chats/[channelId].tsxL961-R965, [1] [2] [3] [4] [5]Backend support for attachment counts:
attachment_countinMmPostParentPreviewand its API, so the client can distinguish between truly empty and attachment-only parent messages. [1] [2]Channel preview consistency:
post.deletedevents to fetch updated previews from the server.Attachment viewer UI improvements (web):