Bug/41 improve package structure by olehnikolaiev · Pull Request #45 · skalenetwork/bite-ts

olehnikolaiev · 2026-04-17T17:21:07Z

fixes #41

add tests to run bite-ts in different environments (node, web, etc) and on different platforms (Ubuntu, MacOS, Windows)

update t-encrypt package

Bug/36 dont use buffer

Copilot

Pull request overview

This PR aims to address #41 by reducing Node-only Buffer usage in core encryption code, exposing byte utilities, and adding cross-environment smoke tests (Node/Web/Workers/Bun/Deno) that are run in CI.

Changes:

Add src/utils/bytes.ts and export hexToBytes / bytesToHex / concatBytes from the package entrypoint.
Replace Buffer-based RLP/hex conversions in encryption paths (and one test) with Uint8Array-based helpers.
Add environment smoke test harnesses (web + Cloudflare Worker + Node/Bun/Deno scripts) and wire them into .github/workflows/test.yml.

Reviewed changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
tests/test_epoch_validation.js	Switches from `Buffer` to exported byte helpers for RLP/hex handling in the test.
src/utils/bytes.ts	Introduces hex/byte conversion + concatenation helpers with hex validation.
src/index.ts	Exports the new byte helpers as part of the public API.
src/core/encrypt.ts	Replaces `Buffer.from(..., 'hex')`/`Buffer.toString('hex')` with `hexToBytes`/`bytesToHex` for RLP encoding.
scripts/env-smoke/worker/wrangler.toml	Adds a Wrangler config for the Worker smoke test.
scripts/env-smoke/worker/src/index.js	Adds a Worker endpoint that runs encryption and validates the RLP payload shape.
scripts/env-smoke/worker/runtime-check.mjs	Adds a Node runner that starts `wrangler dev` and probes for a PASS response.
scripts/env-smoke/worker/package.json	Adds a standalone npm project for the Worker smoke test.
scripts/env-smoke/worker/package-lock.json	Locks dependencies for the Worker smoke test project.
scripts/env-smoke/web/vite.config.js	Adds Vite config for the web smoke test.
scripts/env-smoke/web/src/main.js	Adds browser smoke test logic that runs encryption and validates the RLP payload.
scripts/env-smoke/web/runtime-check.mjs	Adds a Playwright-based runtime check for the web smoke test.
scripts/env-smoke/web/package.json	Adds a standalone npm project for the web smoke test (Vite + Playwright).
scripts/env-smoke/web/package-lock.json	Locks dependencies for the web smoke test project.
scripts/env-smoke/web/index.html	Adds minimal page for displaying PASS/FAIL status.
scripts/env-smoke/shared-fixture.mjs	Adds shared fixture values and helper functions for smoke tests.
scripts/env-smoke/node-smoke.mjs	Adds Node ESM smoke test script validating encryption output.
scripts/env-smoke/node-smoke.cjs	Adds Node CJS smoke test script validating encryption output.
scripts/env-smoke/deno-smoke.ts	Adds Deno smoke test script validating encryption output.
scripts/env-smoke/bun-smoke.mjs	Adds Bun smoke test script validating encryption output.
scripts/env-smoke/README.md	Documents how to run each environment smoke test locally.
scripts/endpoint_by_container/data_dir/config.json	Adds patch timestamps used by containerized test/config flows.
package.json	Bumps package version and adds npm scripts to run environment smoke tests.
examples/confidential-token-demo/src/encryption.js	Updates demo code to use byte helpers instead of Node `Buffer` APIs.
.github/workflows/test.yml	Adds Bun/Deno setup and runs the new environment smoke tests in CI; bumps container tags.

Files not reviewed (2)

scripts/env-smoke/web/package-lock.json: Language not supported
scripts/env-smoke/worker/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-17T17:29:05Z

+function hexToBytes(hex) {
+    const clean = hex.startsWith('0x') ? hex.slice(2) : hex;
+    const bytes = new Uint8Array(clean.length / 2);
+
+    for (let i = 0; i < clean.length; i += 2) {


hexToBytes / bytesToHex are duplicated here and in the worker smoke test. Since a shared helper module exists (scripts/env-smoke/shared-fixture.mjs) and the library now exports byte utilities, consider reusing one of those to avoid divergence between environments.

Copilot · 2026-04-17T17:29:06Z

 {
  "name": "@skalenetwork/bite",
-  "version": "0.8.1",
+  "version": "0.8.2",
  "description": "TS Library to interact with BITE protocol",
  "homepage": "https://github.com/skalenetwork/bite.ts",
  "license": "LGPL-3.0-or-later",


PR description says it “updates t-encrypt package” / fixes #41, but this repo still depends on @skalenetwork/t-encrypt at 0.8.0-develop.0 (see package.json dependencies). Since npm versions are immutable, the Workers/WASM fix likely requires bumping the dependency to the new published version (or updating the PR description if the t-encrypt change is out-of-scope for this PR).

Copilot · 2026-04-17T17:29:07Z

+
+const COMMITTEE_INFO = [
+    {
+        commonBLSPublicKey: '2d3846dc859e04cf130cd58a6b73f6f94def67adbec30df6dcfe0d6ab7d8a280173fff75e7afa1eaaf98b18282ae1a832475602f27480120adca88f6c3febc5b2b3a808057137751edbd32f3b6ec003fe120c53b133b0c25f2d050f123fb36ef2f2e6876d111b220ef84a86deb891c45571907e19366d405692f59e46f443d02',
+        epochId: 777
+    }
+];
+
+const SAMPLE_TX = {
+    to: '0x1234567890123456789012345678901234567890',
+    data: '0x1234abcd'
+};
+


COMMITTEE_INFO (and the related SAMPLE_TX below) are duplicated across the env smoke targets (web/worker/node). Since scripts/env-smoke/shared-fixture.mjs already exists in this PR, consider importing the fixture from there to keep the test vectors consistent and reduce maintenance overhead.

Suggested change

const COMMITTEE_INFO = [

{

commonBLSPublicKey: '2d3846dc859e04cf130cd58a6b73f6f94def67adbec30df6dcfe0d6ab7d8a280173fff75e7afa1eaaf98b18282ae1a832475602f27480120adca88f6c3febc5b2b3a808057137751edbd32f3b6ec003fe120c53b133b0c25f2d050f123fb36ef2f2e6876d111b220ef84a86deb891c45571907e19366d405692f59e46f443d02',

epochId: 777

}

];

const SAMPLE_TX = {

to: '0x1234567890123456789012345678901234567890',

data: '0x1234abcd'

};

import { COMMITTEE_INFO, SAMPLE_TX } from '../../shared-fixture.mjs';

Copilot · 2026-04-17T17:29:07Z

+  "dependencies": {
+    "@skalenetwork/bite": "file:../../.."
+  },
+  "devDependencies": {
+    "playwright": "^1.53.0",
+    "vite": "^6.3.1"
+  }


@ethereumjs/rlp is imported directly by src/main.js, but it isn’t listed in this package’s dependencies/devDependencies. Relying on @skalenetwork/bite’s transitive dependency can break installs (and bundlers) if the dependency tree changes; please add @ethereumjs/rlp explicitly.

Copilot · 2026-04-17T17:29:08Z

+  "dependencies": {
+    "@skalenetwork/bite": "file:../../.."
+  },
+  "devDependencies": {
+    "wrangler": "^3.99.0"
+  }


@ethereumjs/rlp is imported directly by the worker entry (src/index.js), but it isn’t listed in this package’s dependencies/devDependencies. Please add it explicitly to avoid relying on transitive deps (which can break wrangler/esbuild resolution if the tree changes).

Copilot · 2026-04-17T17:29:08Z

+    const npmCmd = process.platform === 'win32' ? 'npm.cmd' : 'npm';
+    const worker = spawn(npmCmd, ['run', 'dev'], {
+        cwd: new URL('.', import.meta.url),
+        stdio: 'pipe'
+    });


spawn(..., { cwd: new URL('.', import.meta.url) }) passes a URL object as cwd. In Node 18 (used in CI), child_process expects a filesystem path string here, so this can throw at runtime. Convert to a path with fileURLToPath(new URL('.', import.meta.url)) (or similar) before passing to spawn.

Copilot · 2026-04-17T17:29:08Z

+    const npmCmd = process.platform === 'win32' ? 'npm.cmd' : 'npm';
+    const cwd = new URL('.', import.meta.url);
+
+    await runCommandAndWait(npmCmd, ['run', 'build'], { cwd });
+
+    const server = runCommand(
+        npmCmd,
+        ['run', 'preview', '--', '--host', HOST, '--port', String(PORT), '--strictPort'],
+        { cwd }
+    );


cwd is set to a URL (new URL('.', import.meta.url)) and then passed to spawn. On Node 18 this is not consistently supported (it expects a path string), which can break the smoke test in CI. Please convert the file URL to a filesystem path (e.g. via fileURLToPath) before using it as cwd.

Copilot · 2026-04-17T17:29:08Z

+function hexToBytes(hex) {
+    const clean = hex.startsWith('0x') ? hex.slice(2) : hex;
+    const bytes = new Uint8Array(clean.length / 2);
+
+    for (let i = 0; i < clean.length; i += 2) {


Helper utilities (hexToBytes / bytesToHex / assert) are redefined here even though similar helpers exist in scripts/env-smoke/shared-fixture.mjs (and @skalenetwork/bite now exports byte helpers). Reusing the shared helper reduces duplication and helps keep behavior identical between smoke targets.

Copilot · 2026-04-17T17:29:09Z

+
+const COMMITTEE_INFO = [
+    {
+        commonBLSPublicKey: '2d3846dc859e04cf130cd58a6b73f6f94def67adbec30df6dcfe0d6ab7d8a280173fff75e7afa1eaaf98b18282ae1a832475602f27480120adca88f6c3febc5b2b3a808057137751edbd32f3b6ec003fe120c53b133b0c25f2d050f123fb36ef2f2e6876d111b220ef84a86deb891c45571907e19366d405692f59e46f443d02',
+        epochId: 777
+    }
+];
+
+const SAMPLE_TX = {
+    to: '0x1234567890123456789012345678901234567890',
+    data: '0x1234abcd'
+};
+


COMMITTEE_INFO (and the related SAMPLE_TX below) are duplicated across the env smoke targets (web/worker/node). Since scripts/env-smoke/shared-fixture.mjs was added in this PR, consider importing the fixture from there so the test vectors stay in sync.

Suggested change

const COMMITTEE_INFO = [

{

commonBLSPublicKey: '2d3846dc859e04cf130cd58a6b73f6f94def67adbec30df6dcfe0d6ab7d8a280173fff75e7afa1eaaf98b18282ae1a832475602f27480120adca88f6c3febc5b2b3a808057137751edbd32f3b6ec003fe120c53b133b0c25f2d050f123fb36ef2f2e6876d111b220ef84a86deb891c45571907e19366d405692f59e46f443d02',

epochId: 777

}

];

const SAMPLE_TX = {

to: '0x1234567890123456789012345678901234567890',

data: '0x1234abcd'

};

import { COMMITTEE_INFO, SAMPLE_TX } from '../../shared-fixture.mjs';

Copilot

Pull request overview

Copilot reviewed 31 out of 38 changed files in this pull request and generated 1 comment.

Files not reviewed (4)

scripts/env-smoke/ts-consumer/bundler/package-lock.json: Language not supported
scripts/env-smoke/ts-consumer/nodenext/package-lock.json: Language not supported
scripts/env-smoke/web/package-lock.json: Language not supported
scripts/env-smoke/worker/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-20T17:46:43Z

+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        node: ['18', '20']
+


The Node matrix includes windows-latest, but the build runs yarn build, which relies on shelling out to POSIX-style commands (e.g. rm -rf dist via the clean script). This is likely to fail on Windows unless the runner environment happens to provide rm. Consider making the clean step cross-platform (e.g. using a Node-based delete or a dedicated cross-platform tool) or running the build steps under shell: bash on Windows runners.

olehnikolaiev and others added 9 commits April 15, 2026 12:08

#36 use uint8array in favor of buffer

1800fd7

#36 update versions for tests

07caede

#36 bump version

2b2efee

#36 use correct patch

29f7863

#36 improve license

18df33c

#36 address comments

c8f1a4d

Merge pull request #44 from skalenetwork/bug/36-dont-use-buffer

7fbd3e5

Bug/36 dont use buffer

#41 add more tests

3bbdb41

#41 fix tests

b37c9d6

olehnikolaiev requested review from a team and DmytroNazarenko as code owners April 17, 2026 17:21

olehnikolaiev requested a review from Copilot April 17, 2026 17:22

Copilot started reviewing on behalf of olehnikolaiev April 17, 2026 17:22 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

olehnikolaiev added 2 commits April 20, 2026 11:41

#41 format

b746308

#41 add more tests

650e405

olehnikolaiev requested a review from Copilot April 20, 2026 17:41

Copilot started reviewing on behalf of olehnikolaiev April 20, 2026 17:42 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

#41 update tests

6ec30dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug/41 improve package structure#45

Bug/41 improve package structure#45
olehnikolaiev wants to merge 12 commits into
stablefrom
bug/41-improve-package-structure

olehnikolaiev commented Apr 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

olehnikolaiev commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

olehnikolaiev commented Apr 17, 2026 •

edited

Loading