fix: wait for SessionStart hook in window picker flow#35
Open
hscheema1979 wants to merge 7 commits intosix-ddc:mainfrom
Open
fix: wait for SessionStart hook in window picker flow#35hscheema1979 wants to merge 7 commits intosix-ddc:mainfrom
hscheema1979 wants to merge 7 commits intosix-ddc:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes race condition in window picker flow where ccbot binds a new topic to an existing tmux window before the SessionStart hook has written the session_map entry.
Problem
When creating a new Telegram topic and using the window picker to select an existing tmux window:
bind_thread()KeyError: "Session not in session_map"Root cause: The SessionStart hook runs asynchronously and needs time to write
session_map.json. The window picker flow was callingbind_thread()immediately after window selection, without waiting for the hook to complete.Solution
Added
wait_for_session_map_entry()call in the window picker callback handler (bot.pyline ~1141):Changes
Testing
See
docs/TESTING_FIX.mdfor detailed testing procedure.Success criteria:
Related
This mirrors the fix already applied to the auto-create flow (line 1033), ensuring consistency across both session creation paths.
🤖 Generated with Claude Code