fix: github action lint #24
Conversation
Lots and lots of linting fixes.
| @@ -0,0 +1,42 @@ | |||
| repos: | |||
There was a problem hiding this comment.
| This project uses [pre-commit](https://pre-commit.com/). | ||
|
|
||
| ```bash | ||
| python3 -m pip install -U pre-commit |
There was a problem hiding this comment.
@pvetere FYI you'll want to run through these steps on your local machine
src/error_handler.py
Outdated
| def abort(s): | ||
| eprint(s) | ||
| os._exit(1) | ||
| sys.exit(1) |
There was a problem hiding this comment.
Hmm. I actually was using os._exit here intentionally to avoid having the exception bubbling out. The sys.exit call apparently causes a SystemExit exception to bubble up to the higher level handlers. In some cases, thought, I just want the program to immediately exit.
There was a problem hiding this comment.
I think we might want to look into this a bit more for a less heavy-handed way of accomplishing the same thing. os._exit() is a sledgehammer.
There was a problem hiding this comment.
I'm going to punt on this for this change and revert back to os._exit().
I gotta say I'm still shocked by the number of foot guns in this language.
There was a problem hiding this comment.
That sounds like a good plan. I'll take the responsibility to go back and fix it later.
3 participants
Lots and lots of linting fixes.