Conversation
mxsrc
force-pushed
the
systemd
branch
7 times, most recently
from
January 20, 2026 16:26
b943436 to
afe7718
Compare
mxsrc
force-pushed
the
systemd
branch
2 times, most recently
from
February 2, 2026 07:22
5a5b274 to
0647f50
Compare
mxsrc
force-pushed
the
systemd
branch
4 times, most recently
from
February 25, 2026 16:15
11dba8e to
7893ab0
Compare
mxsrc
force-pushed
the
systemd
branch
5 times, most recently
from
March 5, 2026 07:29
a126f9a to
484708b
Compare
mxsrc
marked this pull request as ready for review
March 23, 2026 07:59
noctarius
reviewed
Mar 23, 2026
noctarius
left a comment
noctarius
left a comment
Collaborator
There was a problem hiding this comment.
Great PR. Couple of small questions but this is amazing. Love that now, every process also gets its own user.
|
|
||
| ExecStartPre=/bin/sh -c "if [ ! -s ${PGDATA}/PG_VERSION ]; then pg_ctl initdb --options=\"--username=vela --waldir=/var/lib/postgresql/wal/pg_wal\"; fi" | ||
| ExecStartPre=/usr/local/bin/postgres-pitr-setup.sh | ||
| ExecStart=/bin/sh -c "exec postgres -k %t/postgresql -c config_file=/vela/config/postgresql.conf -c hba_file=/vela/config/pg_hba.conf $(cat %t/postgresql/pitr-args)" |
Collaborator
There was a problem hiding this comment.
I think we wanted to to use /etc/postgresql.conf which includes /vela/config/postgresql.conf then the timescaledb-tune output and then a user-override file (like /vela/config/postgresql-user.conf). Should we already prepare that?
Contributor
Author
There was a problem hiding this comment.
That would be nice, I'd rather not include this here and delay further. The change would require controller-changes as well and has implications for migrating existing VMs.
Collaborator
There was a problem hiding this comment.
Fair, let's put this into an issue and link here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the init system to systemd, giving us better control of the process management, inspection methods, and integrated log management.