Implementation of namespaced-volume migration - #399
Open
noctarius wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for “namespaced” (multi-namespace-per-subsystem) volume migrations by detecting whether a volume’s StorageClass provisions shared NVMe subsystems and forwarding that information to the backend as a batch flag on the ContinueMigration call.
Changes:
- Extend the WebAPI ContinueMigration request to optionally send a
batchflag. - Detect multi-namespace volumes from the PV’s StorageClass (
max_namespace_per_subsys > 1) and persist the verdict inVolumeMigrationstatus. - Update CRDs/manifests and add unit tests covering detection + backend flag propagation.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| operator/internal/webapi/rebalancing.go | Adds batch field to ContinueMigration request payload and threads it through the client call. |
| operator/internal/controller/volumemigration_controller.go | Resolves and stores multi-namespace verdict from StorageClass, and passes it to ContinueMigration; adds StorageClass RBAC. |
| operator/internal/controller/volumemigration_controller_unit_test.go | Seeds StorageClasses via client-go fake clientset and adds tests for detection + batch propagation. |
| operator/internal/autoplacement/logical_volume_selector.go | Removes outdated comment near namespaced-set logic. |
| operator/dist/install.yaml | Updates generated install CRD schema to include status.multiNamespace. |
| operator/config/crd/bases/storage.simplyblock.io_volumemigrations.yaml | Updates CRD base schema for status.multiNamespace. |
| operator/api/v1alpha1/volumemigration_types.go | Adds MultiNamespace field to VolumeMigrationStatus. |
| helm-charts/charts/simplyblock-operator/crds/storage.simplyblock.io_volumemigrations.yaml | Updates Helm-packaged CRD schema for status.multiNamespace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
noctarius
force-pushed
the
multi-namespace-volume-migration
branch
2 times, most recently
from
August 5, 2026 13:13
b3ca05b to
949044e
Compare
noctarius
force-pushed
the
multi-namespace-volume-migration
branch
2 times, most recently
from
August 5, 2026 17:10
b5ef1ab to
03d4497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements namespaced-volume (subsystem) migration.