Skip to content

Implementation of namespaced-volume migration - #399

Open
noctarius wants to merge 1 commit into
mainfrom
multi-namespace-volume-migration
Open

Implementation of namespaced-volume migration#399
noctarius wants to merge 1 commit into
mainfrom
multi-namespace-volume-migration

Conversation

@noctarius

Copy link
Copy Markdown
Collaborator

This PR implements namespaced-volume (subsystem) migration.

@noctarius noctarius added this to the 26.3 milestone Aug 5, 2026
@noctarius noctarius self-assigned this Aug 5, 2026
Copilot AI review requested due to automatic review settings August 5, 2026 12:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for “namespaced” (multi-namespace-per-subsystem) volume migrations by detecting whether a volume’s StorageClass provisions shared NVMe subsystems and forwarding that information to the backend as a batch flag on the ContinueMigration call.

Changes:

  • Extend the WebAPI ContinueMigration request to optionally send a batch flag.
  • Detect multi-namespace volumes from the PV’s StorageClass (max_namespace_per_subsys > 1) and persist the verdict in VolumeMigration status.
  • Update CRDs/manifests and add unit tests covering detection + backend flag propagation.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
operator/internal/webapi/rebalancing.go Adds batch field to ContinueMigration request payload and threads it through the client call.
operator/internal/controller/volumemigration_controller.go Resolves and stores multi-namespace verdict from StorageClass, and passes it to ContinueMigration; adds StorageClass RBAC.
operator/internal/controller/volumemigration_controller_unit_test.go Seeds StorageClasses via client-go fake clientset and adds tests for detection + batch propagation.
operator/internal/autoplacement/logical_volume_selector.go Removes outdated comment near namespaced-set logic.
operator/dist/install.yaml Updates generated install CRD schema to include status.multiNamespace.
operator/config/crd/bases/storage.simplyblock.io_volumemigrations.yaml Updates CRD base schema for status.multiNamespace.
operator/api/v1alpha1/volumemigration_types.go Adds MultiNamespace field to VolumeMigrationStatus.
helm-charts/charts/simplyblock-operator/crds/storage.simplyblock.io_volumemigrations.yaml Updates Helm-packaged CRD schema for status.multiNamespace.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread operator/internal/webapi/rebalancing.go
Comment thread operator/internal/controller/volumemigration_controller.go
Comment thread operator/internal/controller/volumemigration_controller.go
@noctarius
noctarius force-pushed the multi-namespace-volume-migration branch 2 times, most recently from b3ca05b to 949044e Compare August 5, 2026 13:13
@noctarius
noctarius force-pushed the multi-namespace-volume-migration branch 2 times, most recently from b5ef1ab to 03d4497 Compare August 5, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants