This repository was archived by the owner on Jul 14, 2026. It is now read-only.
Remove self-signed cluster issuer creation - #25
Open
mxsrc wants to merge 2 commits into
Open
Conversation
This does not belong to the helm chart deployment, this is a step we commonly use for our testing deployments, so having it here is convenient. I argue we should remove it and do it as part of the environment creation wherever necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not belong to the helm chart deployment, this is a step we commonly use for our testing deployments, so having it here is convenient. I argue we should remove it and do it as part of the environment creation wherever necessary.
This also prevents the internal name from being passed in as the external name.