emit event upon filesystem resize completion - #31
Draft
boddumanohar wants to merge 1 commit into
Draft
Conversation
boddumanohar
marked this pull request as ready for review
March 20, 2026 14:48
No changes to the coverage.
HTML Report |
boddumanohar
force-pushed
the
xfs-resize
branch
2 times, most recently
from
March 22, 2026 18:21
ff256c1 to
e35358e
Compare
boddumanohar
force-pushed
the
xfs-resize
branch
from
March 23, 2026 04:21
e35358e to
881c3bf
Compare
There was a problem hiding this comment.
Pull request overview
Adds support for XFS filesystem growth and introduces a mechanism for the neonvm-runner to signal guest filesystem resize completion by emitting Kubernetes Events on the backing PVC.
Changes:
- Detect filesystem type in
neonvm-daemonand switch toxfs_growfsfor XFS volumes. - Pass pod namespace into the runner and add best-effort Kubernetes Event emission on PVC resize success/failure.
- Add RBAC manifests intended to allow Event creation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/neonvm/controllers/vm_controller.go | Adds K8S_POD_NAMESPACE env var to the runner container. |
| neonvm-runner/image-loader/bases/rbac.yaml | Introduces SA/ClusterRole/ClusterRoleBinding to allow creating Events. |
| neonvm-runner/image-loader/bases/kustomization.yaml | Includes the new RBAC resource in the image-loader base. |
| neonvm-runner/cmd/main.go | Builds an in-cluster client (best-effort) and emits PVC Events on resize success/failure. |
| neonvm-runner/cmd/disks.go | Tracks PVC name per block device to associate Events with the correct PVC. |
| neonvm-daemon/cmd/main.go | Adds fs type detection via blkid and selects xfs_growfs vs resize2fs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
boddumanohar
force-pushed
the
xfs-resize
branch
from
March 24, 2026 18:04
c8ca5cf to
e58750b
Compare
boddumanohar
marked this pull request as draft
April 8, 2026 06:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.