fix: correct base quantity labels display in meal editing screen#221
Draft
TomAFrench wants to merge 1 commit intosimonoppowa:tf/enforce-intl-in-cifrom
Draft
fix: correct base quantity labels display in meal editing screen#221TomAFrench wants to merge 1 commit intosimonoppowa:tf/enforce-intl-in-cifrom
TomAFrench wants to merge 1 commit intosimonoppowa:tf/enforce-intl-in-cifrom
Conversation
Collaborator
Author
|
Looks like @shoutingcatana also brought up the issue of developer documentation on how intl is done. I'd be happy to set up a CI check to ensure that the generated intl files are correctly generated if you can share some pointers on what the process is. |
c51e3b2 to
b949d47
Compare
Merged
052a4f0 to
d0fed16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues introduced in #115, notably:
I've updated the
.arbfiles but it's not entirely clear how I should regenerate the localisations.Running
dart run package:intl/generate_localized.dartas suggested in the existing generated files just results in the errorCould not find file 'package:intl/generate_localized.dart'Based onflutter_intlin thepubspec.yamlfile it looks like you're using this extension for intl but if I regenerate the intl files using that then it results in a few hundred new entries.Feel free to push the updated intl files onto this branch directly but it would be nice to have a documented process for how to regenerate these.